Skip to content

Conversation

@dagood
Copy link
Member

@dagood dagood commented Oct 15, 2021

Fixes #6961

Context

BannedApiAnalyzers has some intentional old dependencies and it's not feasible to build it during source-build. It's already been removed from source-build and we need to remove usages. dotnet/roslyn-analyzers#5619

BannedApiAnalyzers isn't one of the analyzers that ends up in the SDK product, so the only reason for source-build to build it is for code validation parity when building MSBuild's C# source code. That would help source-build developers write upstreamable code if the MSBuild C# code needs to be patched, but dev flows aren't the primary goal of source-build right now.

Changes Made

Moved GlobalPackageReference Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" into an item group that is excluded during source-build, so the analyzer isn't referenced or used.

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Oct 25, 2021
@rokonec rokonec merged commit 06796e0 into dotnet:main Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When building from source, don't use Microsoft.CodeAnalysis.BannedApiAnalyzers to avoid the prebuilt dependency

4 participants