Skip to content

Conversation

@jeffkl
Copy link
Contributor

@jeffkl jeffkl commented Nov 21, 2019

This is an implementation of #4925 which allows tasks to get the current project's global properties.

I added an IBuildEngine6 and plumbed the global properties to the appropriate task hosts.

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should accessing this emit a log event? I kinda want it to to minimize the "invisible input" problem.

@jeffkl
Copy link
Contributor Author

jeffkl commented Nov 21, 2019

It seems a little weird to log a message but it does sort of make sense. I had coded up something but I couldn't decide on the message as I'm not sure what it should say?

TaskA requested the current global properties.

Fetching the current global properties for TaskA

Fetched global properties for TaskA

TaskA requested the following global properties:
  Property1: Value1

If there's a message you like, I'll gladly put it in there.

@jeffkl
Copy link
Contributor Author

jeffkl commented Nov 21, 2019

/cc @AndyGerlicher

@AndyGerlicher
Copy link
Contributor

I would say no on logging? If we want that maybe in the style of #4461 which was reverted. Logging the reads seems like a natural extension of that.

@jeffkl
Copy link
Contributor Author

jeffkl commented Nov 22, 2019

@AndyGerlicher I agree, let's add logging events later as part of the bigger effort to capture things that effect the build, what do you think @rainersigwald?

@jeffkl
Copy link
Contributor Author

jeffkl commented Nov 22, 2019

@rainersigwald gentle ping...

@rainersigwald rainersigwald merged commit 81d9a23 into dotnet:master Nov 25, 2019
@jeffkl jeffkl deleted the task-getglobalproperties branch November 25, 2019 22:28
@jeffkl
Copy link
Contributor Author

jeffkl commented Nov 25, 2019

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants