-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Implement feature that allows tasks to get the global properties #4939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should accessing this emit a log event? I kinda want it to to minimize the "invisible input" problem.
|
It seems a little weird to log a message but it does sort of make sense. I had coded up something but I couldn't decide on the message as I'm not sure what it should say? If there's a message you like, I'll gladly put it in there. |
|
/cc @AndyGerlicher |
|
I would say no on logging? If we want that maybe in the style of #4461 which was reverted. Logging the reads seems like a natural extension of that. |
|
@AndyGerlicher I agree, let's add logging events later as part of the bigger effort to capture things that effect the build, what do you think @rainersigwald? |
|
@rainersigwald gentle ping... |
|
Thanks all! |
This is an implementation of #4925 which allows tasks to get the current project's global properties.
I added an
IBuildEngine6and plumbed the global properties to the appropriate task hosts.