Fix logging context validity check #10348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
approved these changes
Jul 10, 2024
akoeplinger
reviewed
Jul 10, 2024
src/Build/BackEnd/Components/RequestBuilder/AssemblyLoadsTracker.cs
Outdated
Show resolved
Hide resolved
JanKrivanek
force-pushed
the
bugfix/context-invalid
branch
from
7e3e1a4 to
95a2e8d
Compare
Member
Author
|
@akoeplinger please note that the bug is not fixed. It'd be nice to see updated evidence once this flows into sdk and that sdk is being applied to VMR build. How often do you update the sdk there? |
f-alizada
approved these changes
Jul 11, 2024
Member
|
@JanKrivanek we can do it on demand as needed. I can also patch/replace any dll in the SDK which is used to build as part of a PR so we can run a couple builds until we hit the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds diagnostics for #10342
Context
Attempted logging with invalid context had cryptic error message. It could happen on AssemblyLoadTracker which should be just a transient error.
The exception can be found in the telemetry even in the past - the recent changes only increased likelyhood.
Changes Made