Skip to content

Revert ios button changes #22300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2024
Merged

Revert ios button changes #22300

merged 2 commits into from
May 9, 2024

Conversation

@PureWeen
Copy link
Member

@PureWeen PureWeen commented May 8, 2024

Description of Change

It looks like these changes are causing an infinite layout loop for some scenarios #22288

We will revisit these changes for SR6

PureWeen added 2 commits May 8, 2024 15:03
@PureWeen
Revert changes for iOS Button Layout Fixes
fb6395a
@PureWeen
Revert "[iOS] Allow compat iOS buttons to resize image and to respect…
39c1ef4 
… spacing and padding (#21759)"

This reverts commit 63eb6b6.

# Conflicts:
#	src/Controls/tests/UITests/snapshots/ios/Issue18242Test.png
@PureWeen PureWeen requested a review from a team as a code owner May 8, 2024 20:09
@PureWeen PureWeen requested review from mattleibow and rmarinho May 8, 2024 20:09
@Eilon Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 8, 2024
@PureWeen
Copy link
Member Author

PureWeen commented May 9, 2024

#22306

@PureWeen PureWeen mentioned this pull request May 9, 2024
Merged
@jsuarezruiz jsuarezruiz added the legacy-area-perf Startup / Runtime performance label May 9, 2024
@PureWeen PureWeen merged commit ddf9d7f into main May 9, 2024
@PureWeen PureWeen deleted the revert_ios_button_changes branch May 9, 2024 08:35
@Eilon Eilon added perf/general The issue affects performance (runtime speed, memory usage, startup time, etc.) (sub: perf) area-controls-button Button, ImageButton and removed legacy-area-perf Startup / Runtime performance legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels May 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mattleibow mattleibow Awaiting requested review from mattleibow mattleibow was automatically assigned from dotnet/dotnet-maui-reviewers

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho was automatically assigned from dotnet/dotnet-maui-reviewers

1 more reviewer

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-controls-button Button, ImageButton fixed-in-8.0.40 fixed-in-9.0.0-preview.5.24307.10 perf/general The issue affects performance (runtime speed, memory usage, startup time, etc.) (sub: perf)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PureWeen @jsuarezruiz @Eilon @samhouts