[generator] Fix property accessor attributes when one accessor's iOS availability is different than the property itself. #17298

rolfbjarne · 2023-01-19T10:42:44Z

This PR handles two scenarios (fixed in separate commits):

Scenario 1:

The property has different availability attributes than the containing type.
The property's accessor(s) do not have availability attributes.

We'd generate the wrong availability attributes for the property accessors,
because we'd take the type's availability attributes and add them to the
accessors.

As for the fix: I can't really explain it. This code is rather impenetrable,
and the parameter names don't make much sense, but whatever I did seems to
work?

And it turns out this fix shows up in an existing test as well (the
generator's Bug35176 test), which I had to modify to remove the expectation of
(now redundant) availability attributes that we no longer produce.

Scenario 2:

Type is available on iOS, tvOS.
Property in the type is available on iOS (and not tvOS).
Property accessor has explicit availability attributes for iOS.

Then the property accessor would get the availability attribute for tvOS from the
type, and not the (un)availability attribute from the property.

The fix is to make sure the parent context is the property (and not the type) when
processing availability attributes for the accessor.

…availability is different than the property itself. In the following scenario: * A property is available on iOS (and implicitly Mac Catalyst). * One of the property accessors is not available on iOS, but still available on Mac Catalyst (explicitly). We'd generate the wrong availability attributes for ... As for the fix: I can't really explain it. This code is rather impenetrable, and the parameter names don't make much sense, but whatever I did seems to work? And it turns out this fix shows up in an existing test as well (the generator's Bug35176 test), which I had to modify to remove the expectation of (redundant) availability attributes that we no longer produce.

… the property itself. Scenario: * Type is available on iOS, tvOS. * Property in the type is available on iOS (and not tvOS). * Property accessor has explicit availability attributes for iOS. Then the property accessor would get the availability attribute for tvOS from the type, and not the (un)availability attribute from the property. The fix is to make sure the parent context is the property (and not the type) when processing availability attributes for the accessor.

vs-mobiletools-engineering-service2 · 2023-01-24T15:19:01Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) Unable to create gist: Response status code does not indicate success: 502 (Bad Gateway). (raw diff) - Please review changes)

Pipeline on Agent
Hash: be7e8f57c74a6ea631147f59a9e4c31c6f2350b8 [PR build]

vs-mobiletools-engineering-service2 · 2023-01-24T15:26:41Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: be7e8f57c74a6ea631147f59a9e4c31c6f2350b8 [PR build]

vs-mobiletools-engineering-service2 · 2023-01-24T15:34:14Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1107.Monterey'
Hash: be7e8f57c74a6ea631147f59a9e4c31c6f2350b8 [PR build]

vs-mobiletools-engineering-service2 · 2023-01-24T19:09:24Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: be7e8f57c74a6ea631147f59a9e4c31c6f2350b8 [PR build]

dalexsoto

Tests give more confidence about the change 👍

This comment has been minimized.

Sign in to view

rolfbjarne force-pushed the generator-accessor-fix branch from 873eff7 to c9ace05 Compare January 20, 2023 07:54

This comment has been minimized.

Sign in to view

rolfbjarne marked this pull request as ready for review January 24, 2023 06:54

rolfbjarne requested a review from dalexsoto as a code owner January 24, 2023 06:54

rolfbjarne force-pushed the main branch from 8f6eb02 to 608765e Compare January 24, 2023 13:29

rolfbjarne requested review from emaf, mandel-macaque and mauroa as code owners January 24, 2023 13:29

rolfbjarne added 2 commits January 24, 2023 14:33

rolfbjarne force-pushed the generator-accessor-fix branch from 967737f to be7e8f5 Compare January 24, 2023 13:33

rolfbjarne removed request for emaf and mauroa January 25, 2023 07:53

dalexsoto approved these changes Jan 25, 2023

View reviewed changes

rolfbjarne merged commit a57695b into dotnet:main Jan 25, 2023

rolfbjarne deleted the generator-accessor-fix branch January 25, 2023 08:28

[generator] Fix property accessor attributes when one accessor's iOS availability is different than the property itself. #17298

[generator] Fix property accessor attributes when one accessor's iOS availability is different than the property itself. #17298

Uh oh!

Conversation

rolfbjarne commented Jan 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 24, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 24, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 24, 2023

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 24, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

dalexsoto left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rolfbjarne commented Jan 19, 2023 •

edited

Loading