[release/6.0.3xx] [msbuild/tools] Fix path issues in the FilterStaticFrameworks task and ExtractBindingLibraries step. Fixes #15289. #15442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d ExtractBindingLibraries step. Fixes dotnet#15289. In the FilterStaticFrameworks task: * Convert Windows-style paths to Mac-style paths. * Give a better error if a framework can't be found. * Don't try to copy frameworks that don't exist on Windows to the Mac. In the ExtractBindingLibrariesStep: * Return a relative path to frameworks we've extracted to make things easier for remote builds. * In the _ComputeFrameworkFilesToPublish target, don't compute the source directory for frameworks using RootDir + Directory, because some frameworks may only exist on the mac, and RootDir + Directory will be a Windows path when building remotely. Instead use 'Identity', which is a relative path and will work on both Windows and Mac. Fixes dotnet#15289.
vs-mobiletools-engineering-service2
requested review from
chamons,
emaf,
mauroa and
rolfbjarne
as code owners
vs-mobiletools-engineering-service2
added
backported
bug
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
📋 [PR Build] API Diff 📋API Current PR diff✅ API Diff (from PR only) (no change) View dotnet API diffView dotnet legacy API diffAPI diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) Pipeline on Agent XAMBOT-1030.Monterey' |
Collaborator
Author
Collaborator
Author
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
Collaborator
Author
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
Collaborator
Author
Member
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2558). |
rolfbjarne
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the FilterStaticFrameworks task:
In the ExtractBindingLibrariesStep:
Return a relative path to frameworks we've extracted to make things easier for
remote builds.
In the _ComputeFrameworkFilesToPublish target, don't compute the source
directory for frameworks using RootDir + Directory, because some frameworks
may only exist on the mac, and RootDir + Directory will be a Windows path
when building remotely. Instead use 'Identity', which is a relative path and
will work on both Windows and Mac.
Fixes #15289.
Backport of #15321