-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Save ConvertTransform as ONNX Operator and Control the Use of Experimental Features with a Flag #947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Introduce a new argument to SaveOnnx, which is OnnxVersion. Two values are currently allowed, "Latest" and "Experimental". Note that "Latest" means that the produced ONNX model meets the latest ONNX release while "Experimental" may produce things not officially supported in ONNX. 2. For (1), the interface of saving ONNX is slightly changed. Now, CanSaveOnnx requires an OnnxContext as its input argument. 3. Add exporter for ConvertTransform. It doesn't use standard ONNX operator.
|
This PR does not reference an issue. Can you please file one and reference it in the PR description? #Resolved |
|
@markusweimer , sure. Thanks for reminding. #Resolved |
|
Can you make sure it pass build system? #Resolved |
codemzs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Ivanidzo4ka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
|
Looks like there's a test which failed: |
Two values are currently allowed, "Latest" and "Experimental".
Note that "Latest" means that the produced ONNX model meets
the latest ONNX release while "Experimental" may produce
things not officially supported in ONNX.
CanSaveOnnx requires an OnnxContext as its input argument,
because if a model can be saved to ONNX depends on the targeted
ONNX version now.
ONNX operator.
Related issue: #945