Skip to content

Conversation

@ericstj
Copy link
Member

@ericstj ericstj commented Mar 5, 2025

Looks like the 18.04 containers were removed in dotnet/dotnet-buildtools-prereqs-docker@fd83c7a#diff-575b0b833a9ff8e4d19b4197fd33b06ba348c24a137f7313fb9be82c8e3feb10

We're now seeing helix failures running tests. Let's update to fix those.

Seeing other usage of 18.04 in our build containers as well, but these aren't failing right now. Also couldn't find the same cross images in the new set - and changing build container can result in dropping support for those older versions, so we should make sure we do the right thing.

Copilot AI review requested due to automatic review settings March 5, 2025 16:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the Helix container image used for Ubuntu Arm32 from ubuntu-18.04 to ubuntu-24.04 in order to resolve Helix test failures caused by the removal of the older 18.04 images.

  • Updates the container image tag in the CI configuration to reflect the new ubuntu-24.04 base.

Reviewed Changes

File Description
.vsts-dotnet-ci.yml Updated helixQueue container image tag to ubuntu-24.04-helix-arm32v7

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.vsts-dotnet-ci.yml:73

  • Ensure that the updated container image tag (ubuntu-24.04-helix-arm32v7) is available and fully supported in the testing environment to prevent potential future failures.
helixQueue: [email protected]/dotnet-buildtools/prereqs:ubuntu-24.04-helix-arm32v7

@ericstj
Copy link
Member Author

ericstj commented Mar 5, 2025

I think we'll still need dotnet/dotnet-buildtools-prereqs-docker#1374 to fix this, but we'll also need this PR since the container we were using is no longer updated.

@codecov
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.97%. Comparing base (12ce84a) to head (d6fba1a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7410   +/-   ##
=======================================
  Coverage   68.97%   68.97%           
=======================================
  Files        1481     1481           
  Lines      273696   273696           
  Branches    28285    28285           
=======================================
+ Hits       188772   188788   +16     
+ Misses      77532    77516   -16     
  Partials     7392     7392           
Flag Coverage Δ
Debug 68.97% <ø> (+<0.01%) ⬆️
production 63.27% <ø> (+<0.01%) ⬆️
test 89.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericstj ericstj requested a review from michaelgsharp March 5, 2025 17:50
@ericstj
Copy link
Member Author

ericstj commented Mar 6, 2025

Seems the new images are broken, but with a new problem:

System.Security.Authentication.AuthenticationException : The remote certificate is invalid because of errors in the certificate chain: NotTimeValid

Seeing this for multiple different servers: nuget.org, openaipublic.blob.core.windows.net - and the same tests pass when run on other images - most likely not a server problem.

Time logged by the test looks accurate - so it would seem that it's not a case of client disagreeing with server on time (though that's a guess).

@ericstj
Copy link
Member Author

ericstj commented Mar 6, 2025

It looks like we can't use Ubuntu 24.04 for testing with .NET 8 on ARM32 because of dotnet/core#9285.

We need a different container for testing ARM32. Ubuntu 22.04 would work, but it seems this is not provided by https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/main/src/ubuntu/manifest.json. I'm asking folks for a recommendation.

@mthalman
Copy link
Member

mthalman commented Mar 6, 2025

It looks like we can't use Ubuntu 24.04 for testing with .NET 8 on ARM32 because of dotnet/core#9285.

We need a different container for testing ARM32. Ubuntu 22.04 would work, but it seems this is not provided by https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/main/src/ubuntu/manifest.json. I'm asking folks for a recommendation.

I have a PR to get this added for 22.04: dotnet/dotnet-buildtools-prereqs-docker#1381

@michaelgsharp michaelgsharp merged commit 454e919 into main Mar 7, 2025
25 checks passed
@michaelgsharp michaelgsharp deleted the update-helix-ubuntu-arm32 branch March 7, 2025 05:28
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants