-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update Helix ubuntu arm32 container #7410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR updates the Helix container image used for Ubuntu Arm32 from ubuntu-18.04 to ubuntu-24.04 in order to resolve Helix test failures caused by the removal of the older 18.04 images.
- Updates the container image tag in the CI configuration to reflect the new ubuntu-24.04 base.
Reviewed Changes
| File | Description |
|---|---|
| .vsts-dotnet-ci.yml | Updated helixQueue container image tag to ubuntu-24.04-helix-arm32v7 |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.vsts-dotnet-ci.yml:73
- Ensure that the updated container image tag (ubuntu-24.04-helix-arm32v7) is available and fully supported in the testing environment to prevent potential future failures.
helixQueue: [email protected]/dotnet-buildtools/prereqs:ubuntu-24.04-helix-arm32v7
|
I think we'll still need dotnet/dotnet-buildtools-prereqs-docker#1374 to fix this, but we'll also need this PR since the container we were using is no longer updated. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7410 +/- ##
=======================================
Coverage 68.97% 68.97%
=======================================
Files 1481 1481
Lines 273696 273696
Branches 28285 28285
=======================================
+ Hits 188772 188788 +16
+ Misses 77532 77516 -16
Partials 7392 7392
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Seems the new images are broken, but with a new problem: Seeing this for multiple different servers: nuget.org, openaipublic.blob.core.windows.net - and the same tests pass when run on other images - most likely not a server problem. Time logged by the test looks accurate - so it would seem that it's not a case of client disagreeing with server on time (though that's a guess). |
|
It looks like we can't use Ubuntu 24.04 for testing with .NET 8 on ARM32 because of dotnet/core#9285. We need a different container for testing ARM32. Ubuntu 22.04 would work, but it seems this is not provided by https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/main/src/ubuntu/manifest.json. I'm asking folks for a recommendation. |
I have a PR to get this added for 22.04: dotnet/dotnet-buildtools-prereqs-docker#1381 |
Looks like the 18.04 containers were removed in dotnet/dotnet-buildtools-prereqs-docker@fd83c7a#diff-575b0b833a9ff8e4d19b4197fd33b06ba348c24a137f7313fb9be82c8e3feb10
We're now seeing helix failures running tests. Let's update to fix those.
Seeing other usage of 18.04 in our build containers as well, but these aren't failing right now. Also couldn't find the same cross images in the new set - and changing build container can result in dropping support for those older versions, so we should make sure we do the right thing.