Enable test coverage #2230
Merged
Enable test coverage #2230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2230 +/- ##
==========================================
+ Coverage 66.08% 69.6% +3.52%
==========================================
Files 638 784 +146
Lines 116423 143822 +27399
Branches 14846 16656 +1810
==========================================
+ Hits 76939 100109 +23170
- Misses 35231 39170 +3939
- Partials 4253 4543 +290
|
Contributor
|
I don't think adding the test folder is valuable for the coverage at this point. |
Eventually codecov.io should support the automatic application of flags based on directory structure. In the meantime, upload the coverage report twice and allow the server to filter and apply the desired flags.
TomFinley
approved these changes
Jan 24, 2019
codemzs
approved these changes
Jan 24, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change works around coverlet-coverage/coverlet#318 to immediately enable correct coverage for test code.