Skip to content

Fix merge break #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2018
Merged

Fix merge break #1327

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1994b17
Fix merge break
yaeldMS Oct 20, 2018
e75e651
Skip failing tests
yaeldMS Oct 20, 2018
6a89759
Simplify CategoricalEstimator ctor call
yaeldMS Oct 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/Microsoft.ML.Tests/Transformers/NAIndicatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public void NAIndicatorMetadataTest()
};

var dataView = ComponentCreation.CreateDataView(Env, data);
var pipe = new CategoricalEstimator(Env, new CategoricalEstimator.ColumnInfo("A", "CatA"));
var pipe = new CategoricalEstimator(Env, new[] { new CategoricalEstimator.ColumnInfo("A", "CatA") });
Copy link
Member

@eerhardt eerhardt Oct 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified to:

var pipe = new CategoricalEstimator(Env, "A", "CatA");

var newpipe = pipe.Append(new NAIndicatorEstimator(Env, new (string input, string output)[] { ("CatA", "NAA") }));
var result = newpipe.Fit(dataView).Transform(dataView);
Assert.True(result.Schema.TryGetColumnIndex("NAA", out var col));
Expand Down