Implements dead branch removal for switch opcode #2905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@vitek-karas ping |
vitek-karas
approved these changes
Nov 3, 2022
| "call System.Void Mono.Linker.Tests.Cases.UnreachableBlock.ComplexConditionsOptimized/TestSwitch::Reached()", | ||
| "br.s il_a", | ||
| })] | ||
| public static void TestOffset () |
Member
There was a problem hiding this comment.
Would it make sense to also add tests to the ComplexConditions - basically the debug version of these tests - since the IL patterns will be somewhat different in that case.
Contributor
Author
There was a problem hiding this comment.
I did only the most straightforward pattern. There are more including pattern matching, nullable, etc that I point I think we need to invest in so will just leave that for next time.
tlakollo
pushed a commit
to tlakollo/linker
that referenced
this pull request
Dec 20, 2022
Fixes dotnet#2888 Commit migrated from dotnet@73e08af
tlakollo
pushed a commit
to tlakollo/runtime
that referenced
this pull request
Dec 22, 2022
Fixes dotnet/linker#2888 Commit migrated from dotnet/linker@73e08af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2888