Skip to content

Revert "[generator] fix NRE encountered when binding AndroidX (#396)" #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2018
Merged

Revert "[generator] fix NRE encountered when binding AndroidX (#396)" #400

merged 1 commit into from
Dec 6, 2018

Conversation

@jonathanpeppers
Copy link
Member

@jonathanpeppers jonathanpeppers commented Dec 6, 2018 •
edited
Loading

This reverts commit 2e68225.

I neglected to test this change in Mono.Android.csproj!

obj\Debug\android-28\mcw\Java.Time.Temporal.ChronoUnit.cs(284,50): error CS0234: The type or namespace name 'ITemporal' does not exist in the namespace 'Java.Time.Temporal' (are you missing an assembly reference?) [C:\Users\jopepper\Desktop\Git\xamarin-android\src\Mono.Android\Mono.Android.csproj]
obj\Debug\android-28\mcw\Java.Time.Temporal.ChronoUnit.cs(284,99): error CS0234: The type or namespace name 'ITemporal' does not exist in the namespace 'Java.Time.Temporal' (are you missing an assembly reference?) [C:\Users\jopepper\Desktop\Git\xamarin-android\src\Mono.Android\Mono.Android.csproj]
obj\Debug\android-28\mcw\Java.Time.Temporal.ChronoUnit.cs(299,56): error CS0234: The type or namespace name 'ITemporal' does not exist in the namespace 'Java.Time.Temporal' (are you missing an assembly reference?) [C:\Users\jopepper\Desktop\Git\xamarin-android\src\Mono.Android\Mono.Android.csproj]
obj\Debug\android-28\mcw\Java.Time.Temporal.ValueRange.cs(113,72): error CS0234: The type or namespace name 'ITemporalField' does not exist in the namespace 'Java.Time.Temporal' (are you missing an assembly reference?) [C:\Users\jopepper\Desktop\Git\xamarin-android\src\Mono.Android\Mono.Android.csproj]
obj\Debug\android-28\mcw\Java.Time.Temporal.ValueRange.cs(128,70): error CS0234: The type or namespace name 'ITemporalField' does not exist in the namespace 'Java.Time.Temporal' (are you missing an assembly reference?) [C:\Users\jopepper\Desktop\Git\xamarin-android\src\Mono.Android\Mono.Android.csproj]

Let's revert this change, and I will look into another fix for the
AndroidX problem. It will likely happen after we branch.

@jonathanpeppers
Revert "[generator] fix NRE encountered when binding AndroidX (dotnet…
b5768ff 
…#396)"

This reverts commit 2e68225.

I neglected to test this change in `Mono.Android.csproj`!

Let's revert this change, and I will look into another fix for the
AndroidX problem. It will likely happen *after* we branch.
@jonpryor jonpryor merged commit 8337615 into dotnet:master Dec 6, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonpryor jonpryor Awaiting requested review from jonpryor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonathanpeppers @jonpryor