Skip to content

Conversation

@wli3
Copy link

@wli3 wli3 commented Oct 9, 2019

  • Remove ubuntu 14.04 and groovey file
  • Remove all old fedora
  • Update to Debian Stretch
    • No debian 9 1.x runtime support
  • Remove rhel.6


# Dockerfile that creates a container suitable to build dotnet-cli
FROM microsoft/dotnet-buildtools-prereqs:fedora-28-c103199-20180628122443
FROM mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-30-39ec319-20190806171718
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mthalman @MichaelSimons I am wondering if you can help me on this issue. I keep getting the following when trying to update the docker image. And I cannot find anywhere setlocale is used in install script

/usr/bin/sh setlocale: LC_ALL: cannot change locale (en_US.UTF-8) [/home/vsts/work/1/s/.nuget/packages/microsoft.dotnet.arcade.sdk/1.0.0-beta.19474.3/tools/Tools.proj]

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wli3 - according to this post, the LANG is misspelled.

Your locale should be en_US.utf8 not en-US.UTF-8

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the docker file to ENV LANG=en_US.utf8 it still won't work.
With the same error message "cannot change locale (en_US.UTF-8)". I don't know what is trying to set en_US.UTF-8

I also find many similar problem like https://github.com/dotnet/coreclr/issues/22823 dotnet/corefx#34385 but still don't know the cause other than "it is a docker authoring issue". Do you know what caused it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Digging a little bit I found this suggestion: https://stackoverflow.com/a/55255020/3182557. It is not the prettiest solution but it seems to work for the experiment I tried.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still won't work :(


# Dockerfile that creates a container suitable to build dotnet-cli
FROM microsoft/dotnet-buildtools-prereqs:alpine-3.6-3148f11-20171119021156
FROM microsoft/dotnet-buildtools-prereqs:alpine-3.9-helix-2e197e0-20190918214006
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mthalman I find the tag on

https://github.com/dotnet/versions/blob/master/build-info/docker/image-info.dotnet-dotnet-buildtools-prereqs-docker-master.json

But i get


Step 1/13 : FROM microsoft/dotnet-buildtools-prereqs:alpine-3.9-helix-2e197e0-20190918214006
manifest for microsoft/dotnet-buildtools-prereqs:alpine-3.9-helix-2e197e0-20190918214006 not found: manifest unknown: manifest unknown
##[error]Bash exited with code '1'.

At the same time, I just trying out different image blindly. A different 3.9 (microsoft/dotnet-buildtools-prereqs:alpine-3.9-helix-af66924-20190215231918) image give me the following, meaning I cannot even run a Arcade restore. Is there any image in used by any Arcade supported build?

Target Name=InitializeSourceControlInformationFromSourceControlManager Project=Microsoft.DotNet.Tools.Tests.Utilities.csproj
    Microsoft.Build.Tasks.Git.LocateRepository
        Assembly = /home/vsts/work/1/s/.nuget/packages/microsoft.build.tasks.git/1.0.0-beta2-18618-05/build/../tools/netcoreapp2.0/Microsoft.Build.Tasks.Git.dll
        Parameters
            Directory = /home/vsts/work/1/s/test/Microsoft.DotNet.Tools.Tests.Utilities
        Errors
            /home/vsts/work/1/s/.nuget/packages/microsoft.build.tasks.git/1.0.0-beta2-18618-05/build/Microsoft.Build.Tasks.Git.targets(20,5): The type initializer for 'LibGit2Sharp.Core.NativeMethods' threw an exception.
   at LibGit2Sharp.Core.NativeMethods.git_buf_free(GitBuf buf)
   at LibGit2Sharp.Core.Proxy.git_buf_free(GitBuf buf)
   at LibGit2Sharp.Core.Handles.GitBuf.Dispose()
   at LibGit2Sharp.Core.Proxy.ConvertPath(Func`2 pathRetriever)
   at LibGit2Sharp.Core.Proxy.git_repository_discover(FilePath start_path)
   at LibGit2Sharp.Repository.Discover(String startingPath)
   at Microsoft.Build.Tasks.Git.GitOperations.LocateRepository(String directory) in /_/src/Microsoft.Build.Tasks.Git.Operations/GitOperations.cs:line 26
   at Microsoft.Build.Tasks.Git.RepositoryTasks.LocateRepository(LocateRepository task) in /_/src/Microsoft.Build.Tasks.Git.Operations/RepositoryTasks.cs:line 58 [/home/vsts/work/1/s/test/Microsoft.DotNet.Tools.Tests.Utilities/Microsoft.DotNet.Tools.Tests.Utilities.csproj]
    RepositoryType = git
    Microsoft.Build.Tasks.Git.GetRepositoryUrl
        Assembly = /home/vsts/work/1/s/.nuget/packages/microsoft.build.tasks.git/1.0.0-beta2-18618-05/build/../tools/netcoreapp2.0/Microsoft.Build.Tasks.Git.dll
    Microsoft.Build.Tasks.Git.GetSourceRevisionId
        Assembly = /home/vsts/work/1/s/.nuget/packages/microsoft.build.tasks.git/1.0.0-beta2-18618-05/build/../tools/netcoreapp2.0/Microsoft.Build.Tasks.Git.dll
    Microsoft.Build.Tasks.Git.GetSourceRoots
        Assembly = /home/vsts/work/1/s/.nuget/packages/microsoft.build.tasks.git/1.0.0-beta2-18618-05/build/../tools/netcoreapp2.0/Microsoft.Build.Tasks.Git.dll
        OutputItems
            SourceRoot = 

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because you're referencing the old repository on Docker Hub that we don't publish to any longer. You should reference it as mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.9-helix-2e197e0-20190918214006.

@wli3 wli3 changed the title WIP Update dockers Update dockers Oct 23, 2019
@wli3 wli3 marked this pull request as ready for review October 23, 2019 18:19
@wli3 wli3 self-assigned this Oct 23, 2019
@wli3 wli3 requested review from a team and dsplaisted October 23, 2019 18:19
@wli3
Copy link
Author

wli3 commented Oct 23, 2019

@dotnet/dotnet-cli mostly just remove old docker files and removing out dated distro legs

@nguerrera
Copy link

How many legs does this remove? Can we target it at 3.0?

@wli3
Copy link
Author

wli3 commented Oct 29, 2019

@nguerrera it removes 5 legs. And I would port it to 3.0. However I am seeing flaky error like dotnet/dotnet-buildtools-prereqs-docker#199 I did some change. But I am not sure the problem is fixed. Now rerun more times to be sure

- Remove ubuntu 14.04 and groovey file
- Remove all old fedora
- Update to Debian Stretch
- Remove rhel.6
	- No debian 9 1.x runtime support
@wli3
Copy link
Author

wli3 commented Oct 29, 2019

No more Debian Stretch error. I will merge it once tests passed

@wli3 wli3 merged commit d660497 into dotnet:release/3.1.1xx Oct 30, 2019
@wli3 wli3 deleted the docker-update branch October 30, 2019 18:44
wli3 pushed a commit to wli3/core-sdk that referenced this pull request Oct 30, 2019
- Remove ubuntu 14.04 and groovey file
- Remove all old fedora
- Update to Debian Stretch
- Remove rhel.6
	- No debian 9 1.x runtime support
nguerrera pushed a commit that referenced this pull request Nov 1, 2019
- Remove ubuntu 14.04 and groovey file
- Remove all old fedora
- Update to Debian Stretch
- Remove rhel.6
	- No debian 9 1.x runtime support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants