Revert PVP flow for sourcelink #15632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Member
|
cc @mmitche |
MichaelSimons
approved these changes
Feb 27, 2023
Member
MichaelSimons
left a comment
MichaelSimons
left a comment
There was a problem hiding this comment.
This will need to be ported to the preview2 branch.
mthalman
added a commit
to mthalman/installer
that referenced
this pull request
Feb 27, 2023
(cherry picked from commit 58164d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the portion of commit ee2f220 from #15437 that enabled PVP flow for sourcelink. This is because it causes prebuilts to be introduced for the following assemblies: System.Text.Json and System.Reflection.Metadata.
Once dotnet/sourcelink#964 is fixed, then this change can be added back, allowing PVP flow for sourcelink.