[release/7.0.2xx] Update dependencies from dotnet/sdk #15078

dotnet-maestro · 2022-12-01T17:15:59Z

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Coherency Updates:
- Microsoft.FSharp.Compiler: from 12.5.0-beta.22580.6 to 12.5.0-beta.22608.3 (parent: Microsoft.NET.Sdk)
- Microsoft.SourceBuild.Intermediate.fsharp: from 7.0.1-beta.22580.6 to 7.0.1-beta.22608.3 (parent: Microsoft.NET.Sdk)
- Microsoft.NET.Test.Sdk: from 17.5.0-preview-20221130-01 to 17.5.0-preview-20221208-02 (parent: Microsoft.NET.Sdk)
- Microsoft.Net.Compilers.Toolset: from 4.5.0-2.22580.13 to 4.5.0-2.22608.26 (parent: Microsoft.NET.Sdk)
- Microsoft.Build: from 17.5.0-preview-22580-01 to 17.5.0-preview-22608-02 (parent: Microsoft.NET.Sdk)
- NuGet.Build.Tasks: from 6.5.0-preview.2.104 to 6.5.0-preview.2.108 (parent: Microsoft.NET.Sdk)

From https://github.com/dotnet/sdk

Subscription: 7e9ae87f-1b47-4406-1bce-08daa310dc49
Build: 20221209.2
Date Produced: December 9, 2022 9:39:23 AM UTC
Commit: 1fd76f4
Branch: refs/heads/release/7.0.2xx

Updates:
- Microsoft.DotNet.Common.ItemTemplates: from 7.0.200-preview.22580.54 to 7.0.200-preview.22609.2
- Microsoft.DotNet.MSBuildSdkResolver: from 7.0.200-preview.22580.54 to 7.0.200-preview.22609.2
- Microsoft.NET.Sdk: from 7.0.200-preview.22580.54 to 7.0.200-preview.22609.2
- Microsoft.TemplateEngine.Cli: from 7.0.200-preview.22580.54 to 7.0.200-preview.22609.2
- Microsoft.FSharp.Compiler: from 12.5.0-beta.22580.6 to 12.5.0-beta.22608.3
- Microsoft.SourceBuild.Intermediate.fsharp: from 7.0.1-beta.22580.6 to 7.0.1-beta.22608.3
- Microsoft.NET.Test.Sdk: from 17.5.0-preview-20221130-01 to 17.5.0-preview-20221208-02
- Microsoft.Net.Compilers.Toolset: from 4.5.0-2.22580.13 to 4.5.0-2.22608.26
- Microsoft.Build: from 17.5.0-preview-22580-01 to 17.5.0-preview-22608-02
- NuGet.Build.Tasks: from 6.5.0-preview.2.104 to 6.5.0-preview.2.108

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22601.6 Dependency coherency updates Microsoft.NET.Test.Sdk From Version 17.5.0-preview-20221130-01 -> To Version 17.5.0-preview-20221201-01 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22601.11 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22601.2 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22601.22 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22601.2 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22601.38 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22601.2 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22601.40 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22601.4 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22602.5 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22601.4 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22602.6 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22601.4 (parent: Microsoft.NET.Sdk

v-wuzhai · 2022-12-05T10:07:13Z

@dotnet/source-build-internal Could you take a look at the failures here?

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22605.7 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22601.4 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22605.11 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22602.3 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22606.1 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22602.3 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22606.6 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22605.2 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22606.9 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22606.3 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22607.6 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22606.3 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22607.8 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22606.3 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22607.10 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22606.3 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22607.12 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22606.3 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22607.18 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22607.3 (parent: Microsoft.NET.Sdk

marcpopMSFT · 2022-12-08T21:10:56Z

@dotnet/source-build-internal there are 9 failing tests in the tarbal leg to look at.

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22608.6 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22607.3 (parent: Microsoft.NET.Sdk

MichaelSimons · 2022-12-08T22:06:42Z

@nohwnd, @Haplois, @Evangelink - Could one of you help investigate the vstest related failures we are seeing in the source-build smoke-tests.

System.InvalidOperationException : Failed to execute /tarball/test/Microsoft.DotNet.SourceBuild.SmokeTests/bin/Release/net7.0/.dotnet/dotnet test /bl:/tarball/test/Microsoft.DotNet.SourceBuild.SmokeTests/bin/Release/net7.0/logs/BasicScenarioTests_XUnit_CSharp-test.binlog
Exit code: 1
Determining projects to restore...
All projects are up-to-date for restore.
/tarball/test/Microsoft.DotNet.SourceBuild.SmokeTests/bin/Release/net7.0/.dotnet/sdk/7.0.200-preview.22608.1/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(275,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/tarball/test/Microsoft.DotNet.SourceBuild.SmokeTests/bin/Release/net7.0/projects-202212080530129157/BasicScenarioTests_XUnit_CSharp/BasicScenarioTests_XUnit_CSharp.csproj]
BasicScenarioTests_XUnit_CSharp -> /tarball/test/Microsoft.DotNet.SourceBuild.SmokeTests/bin/Release/net7.0/projects-202212080530129157/BasicScenarioTests_XUnit_CSharp/bin/Debug/net7.0/BasicScenarioTests_XUnit_CSharp.dll
Test run for /tarball/test/Microsoft.DotNet.SourceBuild.SmokeTests/bin/Release/net7.0/projects-202212080530129157/BasicScenarioTests_XUnit_CSharp/bin/Debug/net7.0/BasicScenarioTests_XUnit_CSharp.dll (.NETCoreApp,Version=v7.0)
Microsoft (R) Test Execution Command Line Tool Version 17.5.0+81e2a78c4e5645610a64cc37abdd2d3d0e37d387 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.
Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Extensions.FileSystemGlobbing, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified.

File name: 'Microsoft.Extensions.FileSystemGlobbing, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'
at vstest.console.Internal.FilePatternParser..ctor()
at Microsoft.VisualStudio.TestPlatform.CommandLine.CommandLineOptions..ctor()
at Microsoft.VisualStudio.TestPlatform.CommandLine.CommandLineOptions.get_Instance()
at Microsoft.VisualStudio.TestPlatform.CommandLine.Processors.TestAdapterPathArgumentProcessor.<>c.<get_Executor>b__6_0()
at System.Lazy1.ViaFactory(LazyThreadSafetyMode mode) at System.Lazy1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
at System.Lazy1.CreateValue() at Microsoft.VisualStudio.TestPlatform.CommandLine.Processors.ArgumentProcessorFactory.<>c__DisplayClass20_0.<WrapLazyProcessorToInitializeOnInstantiation>b__0() at System.Lazy1.PublicationOnlyViaFactory(LazyHelper initializer)
at System.Lazy1.CreateValue() at Microsoft.VisualStudio.TestPlatform.CommandLine.Executor.GetArgumentProcessors(String[] args, List1& processors)
at Microsoft.VisualStudio.TestPlatform.CommandLine.Executor.Execute(String[] args)
at Microsoft.VisualStudio.TestPlatform.CommandLine.Program.Main(String[] args)

The test is running the following commands

Executing: /tarball/test/Microsoft.DotNet.SourceBuild.SmokeTests/bin/Release/net7.0/.dotnet/dotnet new xunit --name BasicScenarioTests_XUnit_CSharp --output /tarball/test/Microsoft.DotNet.SourceBuild.SmokeTests/bin/Release/net7.0/projects-202212080530129157/BasicScenarioTests_XUnit_CSharp --language "C#" 
Executing: /tarball/test/Microsoft.DotNet.SourceBuild.SmokeTests/bin/Release/net7.0/.dotnet/dotnet test /bl:/tarball/test/Microsoft.DotNet.SourceBuild.SmokeTests/bin/Release/net7.0/logs/BasicScenarioTests_XUnit_CSharp-test.binlog

In this dependency flow the vstest commit sha is being updated: https://github.com/microsoft/vstest/compare/dbdb1f6f9007a288c904aa1f13485a3e57080fb6..81e2a78c4e5645610a64cc37abdd2d3d0e37d387

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22608.8 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22608.1 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22608.10 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22608.3 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.200-preview.22580.54 -> To Version 7.0.200-preview.22609.2 Dependency coherency updates Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks From Version 12.5.0-beta.22580.6 -> To Version 12.5.0-beta.22608.3 (parent: Microsoft.NET.Sdk

MarcoRossignoli · 2022-12-09T11:00:57Z

@MichaelSimons can you point me to the /tarball/test/Microsoft.DotNet.SourceBuild.SmokeTests/bin/Release/net7.0/.dotnet/dotnet assets used(to download)? We're building with an old version of Microsoft.Extensions.FileSystemGlobbing(1.1.1) I wonder why is looking for 7.0.0 do you know if it's changed something for that?

If I look at my local 7.0.100 win sdk I see our old version in the folder "C:\Program Files\dotnet\sdk\7.0.100\Microsoft.Extensions.FileSystemGlobbing.dll" so maybe some other part of the SDK is using a new version and we have to bump it?

I did a source build on my wsl and also there I see 1.1.1 version used and I cannot repro(dotnet exec vstest.console.dll --TestAdapterPath:/randomfolder).

cc: @Evangelink

MichaelSimons · 2022-12-09T14:58:03Z

@MarcoRossignoli - Here is the SDK the PR validation produced - https://artprodcus3.artifacts.visualstudio.com/A6fcc92e5-73a7-4f88-8d13-d9045b45fb27/cbb18261-c48f-4abb-8651-8cdcb5474649/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL2RuY2VuZy1wdWJsaWMvcHJvamVjdElkL2NiYjE4MjYxLWM0OGYtNGFiYi04NjUxLThjZGNiNTQ3NDY0OS9idWlsZElkLzEwNzEyNC9hcnRpZmFjdE5hbWUvQnVpbGRfVGFyYmFsbF94NjQrQ2VudE9TU3RyZWFtOC1PbmxpbmVfQXJ0aWZhY3Rz0/content?format=file&subPath=%2Fdotnet-sdk-7.0.200-preview.22609.1-centos.8-x64.tar.gz. Note this is a rid specific SDK (centos.8). If you want to run it, you can use the following container - mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream8

I am guessing the Microsoft.Extensions.FileSystemGlobbing reference is getting lifted by source-build to the version included in source-build (7.0.0). This binlogs are captured in CI if needed.

MarcoRossignoli · 2022-12-09T16:36:50Z

I'm able to repro, trying to bump to 7.0.0 I'll let you know asap.

MarcoRossignoli · 2022-12-09T17:09:33Z

I did a workaround PR to unblock the installer here microsoft/vstest#4186

Local manual testing looks good, let's see how it will go the journey to the installer.

…d2' of https://github.com/dotnet/installer into darc-release/7.0.2xx-b09871e1-4455-4b2f-a5fe-a12a074510d2

MichaelSimons · 2022-12-09T18:32:42Z

@MarcoRossignoli, Thanks, I pulled in your fix as a source-build patch so that we can test the e2e and unblock this PR.

MichaelSimons · 2022-12-09T20:08:28Z

@MarcoRossignoli - Looks like the tests failed with the same error.

MarcoRossignoli · 2022-12-09T20:57:44Z

Mmm weird, if I download the package generated by the source-build pipeline after the patch https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7076204&view=artifacts&pathAsName=false&type=publishedArtifacts I see the correct 7.0.0 version for Microsoft.Extensions.FileSystemGlobbing

Is it possible that for some reason the old package is "restored"?

MichaelSimons · 2022-12-09T22:03:26Z

I just realized this issue only is affecting the online build; not the online build. Pulling the two sdks from CI, the online build includes a 6.0 version of Microsoft.Extensions.FileSystemGlobbing while the offline build includes a 7.0 version.

joeloff · 2022-12-09T22:59:54Z

I just realized this issue only is affecting the online build; not the online build. Pulling the two sdks from CI, the online build includes a 6.0 version of Microsoft.Extensions.FileSystemGlobbing while the offline build includes a 7.0 version.

I recently found an issue where vstest was flowing the 1.1 copy and overwrote the CLI's copy. Do you think this might be a feed issue? Here's the commit from the SDK in main that solved the problem: dotnet/sdk@b55b5ae

MarcoRossignoli · 2022-12-10T08:42:58Z

Got it, is there some MSbuild var we can use to add another workaround?

Is there "a good" way to fix it?

It's not clear to me what's happening and why the version we're using is not preserved or sometime overridden.

MichaelSimons · 2022-12-12T19:23:55Z

I tracked this down and it is actually the NuGet.Client that is causing the SDK to pickup a 6.0 version of Microsoft.Extensions.FileSystemGlobbing. This is only breaking in offline because the way the package reference is defined, the 6.0 version is the minimum required version. When building offline, NuGet is forced to pickup the 7.0 version which is what source-build is building. I logged NuGet/Home#12317 to track fixing NuGet.

MichaelSimons · 2022-12-12T19:25:06Z

@MarcoRossignoli, I forgot to explicitly call out that the vstest fix you proposed should not be necessary. Thanks for the help investigating.

MichaelSimons · 2022-12-12T19:25:55Z

This PR has been superseded by #15115

MarcoRossignoli · 2022-12-12T19:27:45Z

Thanks I'll revert it asap

dotnet-maestro bot added 7 commits December 1, 2022 17:15

dotnet-maestro bot added 10 commits December 6, 2022 00:26

dotnet-maestro bot added 3 commits December 8, 2022 22:50

MarcoRossignoli mentioned this pull request Dec 9, 2022

Set specific version of Microsoft.Extensions.FileSystemGlobbing to fix source build tests on centos microsoft/vstest#4186

Merged

Add vstest source-build patch

586b74a

Merge branch 'darc-release/7.0.2xx-b09871e1-4455-4b2f-a5fe-a12a074510…

4f813b0

…d2' of https://github.com/dotnet/installer into darc-release/7.0.2xx-b09871e1-4455-4b2f-a5fe-a12a074510d2

MichaelSimons requested a review from a team as a code owner December 9, 2022 18:31

MichaelSimons mentioned this pull request Dec 12, 2022

[release/7.0.2xx] Update dependencies from dotnet/sdk #15115

Merged

MichaelSimons closed this Dec 12, 2022

MarcoRossignoli mentioned this pull request Dec 13, 2022

Revert "Set specific version of Microsoft.Extensions.FileSystemGlobbi… microsoft/vstest#4195

Merged

akoeplinger deleted the darc-release/7.0.2xx-b09871e1-4455-4b2f-a5fe-a12a074510d2 branch February 5, 2024 19:31

[release/7.0.2xx] Update dependencies from dotnet/sdk #15078

[release/7.0.2xx] Update dependencies from dotnet/sdk #15078

Uh oh!

Conversation

dotnet-maestro bot commented Dec 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coherency Updates

From https://github.com/dotnet/sdk

Uh oh!

v-wuzhai commented Dec 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcpopMSFT commented Dec 8, 2022

Uh oh!

MichaelSimons commented Dec 8, 2022

Uh oh!

MarcoRossignoli commented Dec 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelSimons commented Dec 9, 2022

Uh oh!

MarcoRossignoli commented Dec 9, 2022

Uh oh!

MarcoRossignoli commented Dec 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelSimons commented Dec 9, 2022

Uh oh!

MichaelSimons commented Dec 9, 2022

Uh oh!

MarcoRossignoli commented Dec 9, 2022

Uh oh!

MichaelSimons commented Dec 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joeloff commented Dec 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MarcoRossignoli commented Dec 10, 2022

Uh oh!

MichaelSimons commented Dec 12, 2022

Uh oh!

MichaelSimons commented Dec 12, 2022

Uh oh!

MichaelSimons commented Dec 12, 2022

Uh oh!

MarcoRossignoli commented Dec 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dotnet-maestro bot commented Dec 1, 2022 •

edited

Loading

v-wuzhai commented Dec 5, 2022 •

edited

Loading

MarcoRossignoli commented Dec 9, 2022 •

edited

Loading

MarcoRossignoli commented Dec 9, 2022 •

edited

Loading

MichaelSimons commented Dec 9, 2022 •

edited

Loading

joeloff commented Dec 9, 2022 •

edited

Loading