[automated] Merge branch 'release/dev17.14' => 'release/dev18.0'

.config/dotnet-tools.json

@@ -45,7 +45,7 @@
       "rollForward": true
     },
     "fantomas": {
-      "version": "6.2.3",
+      "version": "7.0.1",
       "commands": [
         "fantomas"
       ],

.config/service-branch-merge.json

@@ -5,6 +5,10 @@
             "MergeToBranch": "main",
             "ExtraSwitches": "-QuietComments"
         },
+        "release/dev17.14": {
+            "MergeToBranch": "release/dev18.0",
+            "ExtraSwitches": "-QuietComments"
+        },
         "main": {
             "MergeToBranch": "release/dev17.14",
             "ExtraSwitches": "-QuietComments"

.gitignore

@@ -134,4 +134,6 @@ positive.exe
 /tests/FSharp.Compiler.ComponentTests/FSharpChecker/StandardOutput.txt
 
 # ilverify baseline result files
-*.bsl.actual
+*.bsl.actual
+/src/FSharp.DependencyManager.Nuget/StandardError.txt
+/src/FSharp.DependencyManager.Nuget/StandardOutput.txt

NuGet.config

@@ -8,7 +8,7 @@
     <clear />
     <!--Begin: Package sources managed by Dependency Flow automation. Do not edit the sources below.-->
     <!--  Begin: Package sources from DotNet-msbuild-Trusted -->
-    <add key="darc-pub-DotNet-msbuild-Trusted-0586a3f" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-DotNet-msbuild-Trusted-0586a3f9/nuget/v3/index.json" />
+    <add key="darc-pub-DotNet-msbuild-Trusted-0ca03f8" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-DotNet-msbuild-Trusted-0ca03f84/nuget/v3/index.json" />
     <!--  End: Package sources from DotNet-msbuild-Trusted -->
     <!--End: Package sources managed by Dependency Flow automation. Do not edit the sources above.-->
     <add key="dotnet-eng" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" />

docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@@ -1,4 +1,5 @@
 ### Fixed
+* Fix missing TailCall warning in TOp.IntegerForLoop ([PR #18399](https://github.com/dotnet/fsharp/pull/18399))
 * Fix classification of `nameof` in `nameof<'T>`, `match … with nameof ident -> …`. ([Issue #10026](https://github.com/dotnet/fsharp/issues/10026), [PR #18300](https://github.com/dotnet/fsharp/pull/18300))
 * Fix Realsig+ generates nested closures with incorrect Generic  ([Issue #17797](https://github.com/dotnet/fsharp/issues/17797), [PR #17877](https://github.com/dotnet/fsharp/pull/17877))
 * Fix optimizer internal error for records with static fields  ([Issue #18165](https://github.com/dotnet/fsharp/issues/18165), [PR #18280](https://github.com/dotnet/fsharp/pull/18280))
@@ -18,6 +19,7 @@
 * Miscellanous parentheses analyzer fixes. ([PR #18350](https://github.com/dotnet/fsharp/pull/18350))
 * Fix duplicate parse error reporting for GetBackgroundCheckResultsForFileInProject ([Issue #18379](https://github.com/dotnet/fsharp/issues/18379) [PR #18380](https://github.com/dotnet/fsharp/pull/18380))
 * Fix MethodDefNotFound when compiling code invoking delegate with option parameter ([Issue #5171](https://github.com/dotnet/fsharp/issues/5171), [PR #18385](https://github.com/dotnet/fsharp/pull/18385))
+* Fix #r nuget ..." downloads unneeded packages ([Issue #18231](https://github.com/dotnet/fsharp/issues/18231), [PR #18393](https://github.com/dotnet/fsharp/pull/18393))
 
 ### Added
 * Added missing type constraints in FCS. ([PR #18241](https://github.com/dotnet/fsharp/pull/18241))
@@ -30,7 +32,6 @@
 
 
 ### Changed
-
 * FSharpCheckFileResults.ProjectContext.ProjectOptions will not be available when using the experimental Transparent Compiler feature. ([PR #18205](https://github.com/dotnet/fsharp/pull/18205))
 * Update `Obsolete` attribute checking to account for `DiagnosticId` and `UrlFormat` properties. ([PR #18224](https://github.com/dotnet/fsharp/pull/18224))
 * Remove `Cancellable.UsingToken` from tests ([PR #18276](https://github.com/dotnet/fsharp/pull/18276))

docs/release-notes/.VisualStudio/17.14.md

@@ -1,4 +1,5 @@
 ### Fixed
+* Fix #r nuget ..." downloads unneeded packages ([Issue #18231](https://github.com/dotnet/fsharp/issues/18231), [PR #18393](https://github.com/dotnet/fsharp/pull/18393))
 
 ### Added
 * Add a switch to determine whether to generate a default implementation body for overridden method when completing. [PR #18341](https://github.com/dotnet/fsharp/pull/18341)

eng/Version.Details.xml

@@ -1,32 +1,32 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Dependencies>
   <ProductDependencies>
-    <Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="9.0.0-alpha.1.25163.3">
+    <Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="9.0.0-alpha.1.25170.3">
       <Uri>https://github.com/dotnet/source-build-reference-packages</Uri>
-      <Sha>27dfbb8d8a0344d845948109a5a1f0d9c7f17fa9</Sha>
+      <Sha>6968f7059f4418e985febe704a3b1320f9e5887d</Sha>
       <SourceBuild RepoName="source-build-reference-packages" ManagedOnly="true" />
     </Dependency>
     <!-- Intermediate is necessary for source build. -->
-    <Dependency Name="Microsoft.SourceBuild.Intermediate.msbuild" Version="17.13.21-preview-25169-06">
+    <Dependency Name="Microsoft.SourceBuild.Intermediate.msbuild" Version="17.13.22-preview-25174-08">
       <Uri>https://github.com/dotnet/msbuild</Uri>
-      <Sha>0586a3f904d83c5f77f8407661429caadcbdc5f9</Sha>
+      <Sha>0ca03f84b7848ce9d7d3e5d1f68c5e090efa4f30</Sha>
       <SourceBuild RepoName="msbuild" ManagedOnly="true" />
     </Dependency>
-    <Dependency Name="Microsoft.Build" Version="17.13.21">
+    <Dependency Name="Microsoft.Build" Version="17.13.22">
       <Uri>https://github.com/dotnet/msbuild</Uri>
-      <Sha>0586a3f904d83c5f77f8407661429caadcbdc5f9</Sha>
+      <Sha>0ca03f84b7848ce9d7d3e5d1f68c5e090efa4f30</Sha>
     </Dependency>
-    <Dependency Name="Microsoft.Build.Framework" Version="17.13.21">
+    <Dependency Name="Microsoft.Build.Framework" Version="17.13.22">
       <Uri>https://github.com/dotnet/msbuild</Uri>
-      <Sha>0586a3f904d83c5f77f8407661429caadcbdc5f9</Sha>
+      <Sha>0ca03f84b7848ce9d7d3e5d1f68c5e090efa4f30</Sha>
     </Dependency>
-    <Dependency Name="Microsoft.Build.Tasks.Core" Version="17.13.21">
+    <Dependency Name="Microsoft.Build.Tasks.Core" Version="17.13.22">
       <Uri>https://github.com/dotnet/msbuild</Uri>
-      <Sha>0586a3f904d83c5f77f8407661429caadcbdc5f9</Sha>
+      <Sha>0ca03f84b7848ce9d7d3e5d1f68c5e090efa4f30</Sha>
     </Dependency>
-    <Dependency Name="Microsoft.Build.Utilities.Core" Version="17.13.21">
+    <Dependency Name="Microsoft.Build.Utilities.Core" Version="17.13.22">
       <Uri>https://github.com/dotnet/msbuild</Uri>
-      <Sha>0586a3f904d83c5f77f8407661429caadcbdc5f9</Sha>
+      <Sha>0ca03f84b7848ce9d7d3e5d1f68c5e090efa4f30</Sha>
     </Dependency>
     <Dependency Name="System.Reflection.Metadata" Version="8.0.0">
       <Uri>https://github.com/dotnet/runtime</Uri>

eng/Versions.props

@@ -94,7 +94,7 @@
     <MicrosoftVisualStudioShellPackagesVersion>17.10.40152</MicrosoftVisualStudioShellPackagesVersion>
     <VisualStudioProjectSystemPackagesVersion>17.10.526-pre-g1b474069f5</VisualStudioProjectSystemPackagesVersion>
     <MicrosoftVisualStudioThreadingPackagesVersion>17.10.41</MicrosoftVisualStudioThreadingPackagesVersion>
-    <MicrosoftBuildVersion>17.13.21</MicrosoftBuildVersion>
+    <MicrosoftBuildVersion>17.13.22</MicrosoftBuildVersion>
     <!-- Roslyn packages -->
     <MicrosoftCodeAnalysisEditorFeaturesVersion>$(RoslynVersion)</MicrosoftCodeAnalysisEditorFeaturesVersion>
     <MicrosoftCodeAnalysisEditorFeaturesTextVersion>$(RoslynVersion)</MicrosoftCodeAnalysisEditorFeaturesTextVersion>
@@ -130,9 +130,9 @@
     <MicrosoftVisualStudioShellImmutable150Version>15.0.25123-Dev15Preview</MicrosoftVisualStudioShellImmutable150Version>
     <!-- -->
     <!-- Microsoft Build packages -->
-    <MicrosoftBuildFrameworkVersion>17.13.21</MicrosoftBuildFrameworkVersion>
-    <MicrosoftBuildTasksCoreVersion>17.13.21</MicrosoftBuildTasksCoreVersion>
-    <MicrosoftBuildUtilitiesCoreVersion>17.13.21</MicrosoftBuildUtilitiesCoreVersion>
+    <MicrosoftBuildFrameworkVersion>17.13.22</MicrosoftBuildFrameworkVersion>
+    <MicrosoftBuildTasksCoreVersion>17.13.22</MicrosoftBuildTasksCoreVersion>
+    <MicrosoftBuildUtilitiesCoreVersion>17.13.22</MicrosoftBuildUtilitiesCoreVersion>
     <!-- -->
     <!-- Visual Studio Editor packages -->
     <MicrosoftVisualStudioCoreUtilityVersion>$(VisualStudioEditorPackagesVersion)</MicrosoftVisualStudioCoreUtilityVersion>

global.json

@@ -1,10 +1,10 @@
 {
   "sdk": {
-    "version": "9.0.200",
+    "version": "9.0.202",
     "allowPrerelease": true
   },
   "tools": {
-    "dotnet": "9.0.200",
+    "dotnet": "9.0.202",
     "vs": {
       "version": "17.8",
       "components": [

src/Compiler/AbstractIL/ilnativeres.fs

@@ -83,15 +83,15 @@ type CvtResFile() =
                     pAdditional.DataSize <- cbData
                     pAdditional.pstringType <- CvtResFile.ReadStringOrID reader
                     pAdditional.pstringName <- CvtResFile.ReadStringOrID reader
-                    stream.Position <- stream.Position + 3L &&& ~~~ 3L
+                    stream.Position <- stream.Position + 3L &&& ~~~3L
                     pAdditional.DataVersion <- reader.ReadUInt32()
                     pAdditional.MemoryFlags <- reader.ReadUInt16()
                     pAdditional.LanguageId <- reader.ReadUInt16()
                     pAdditional.Version <- reader.ReadUInt32()
                     pAdditional.Characteristics <- reader.ReadUInt32()
                     pAdditional.data <- Array.zeroCreate (int pAdditional.DataSize)
                     reader.Read(pAdditional.data, 0, pAdditional.data.Length) |> ignore<int>
-                    stream.Position <- stream.Position + 3L &&& ~~~ 3L
+                    stream.Position <- stream.Position + 3L &&& ~~~3L
 
                     if
                         pAdditional.pstringType.theString = Unchecked.defaultof<_>
@@ -174,6 +174,7 @@ type SectionCharacteristics =
 type ResourceSection() =
     new(sectionBytes: byte[], relocations: uint32[]) as this =
         (ResourceSection())
+
         then
             Debug.Assert(sectionBytes :> obj <> Unchecked.defaultof<_>)
             Debug.Assert(relocations :> obj <> Unchecked.defaultof<_>)
@@ -374,13 +375,8 @@ type VersionHelper() =
     ///
     /// <returns>True when parsing succeeds completely (i.e. every character in the string was consumed), false otherwise.</returns>
     static member private TryParse
-        (
-            s: string,
-            allowWildcard: bool,
-            maxValue: uint16,
-            allowPartialParse: bool,
-            [<Out>] version: byref<Version>
-        ) =
+        (s: string, allowWildcard: bool, maxValue: uint16, allowPartialParse: bool, [<Out>] version: byref<Version>)
+        =
         Debug.Assert(not allowWildcard || maxValue < UInt16.MaxValue)
 
         if String.IsNullOrWhiteSpace s then
@@ -520,20 +516,24 @@ type VersionResourceSerializer() =
 
     member val private _isDll = Unchecked.defaultof<bool> with get, set
 
-    new(isDll: bool,
-        comments: string,
-        companyName: string,
-        fileDescription: string,
-        fileVersion: string,
-        internalName: string,
-        legalCopyright: string,
-        legalTrademark: string,
-        originalFileName: string,
-        productName: string,
-        productVersion: string,
-        assemblyVersion: Version) as this =
+    new
+        (
+            isDll: bool,
+            comments: string,
+            companyName: string,
+            fileDescription: string,
+            fileVersion: string,
+            internalName: string,
+            legalCopyright: string,
+            legalTrademark: string,
+            originalFileName: string,
+            productName: string,
+            productVersion: string,
+            assemblyVersion: Version
+        ) as this =
 
         VersionResourceSerializer()
+
         then
             this._isDll <- isDll
             this._commentsContents <- comments
@@ -620,7 +620,7 @@ type VersionResourceSerializer() =
     static member private PadKeyLen(cb: int) =
         VersionResourceSerializer.PadToDword(cb + 3 * sizeof<WORD>) - 3 * sizeof<WORD>
 
-    static member private PadToDword(cb: int) = cb + 3 &&& ~~~ 3
+    static member private PadToDword(cb: int) = cb + 3 &&& ~~~3
 
     static member val private HDRSIZE = (int (3 * sizeof<uint16>)) with get, set
 
@@ -667,7 +667,7 @@ type VersionResourceSerializer() =
         let mutable (sum: int) = 0
 
         for verString in this.GetVerStrings() do
-            sum <- sum + 3 &&& ~~~ 3
+            sum <- sum + 3 &&& ~~~3
             sum <- sum + VersionResourceSerializer.SizeofVerString(verString.Key, verString.Value)
 
         sum
@@ -801,7 +801,7 @@ type VersionResourceSerializer() =
 
         for entry in this.GetVerStrings() do
             let mutable writerPos = writer.BaseStream.Position
-            writer.Write(Array.zeroCreate (int ((writerPos + 3L) &&& ~~~ 3L - writerPos)): byte[])
+            writer.Write(Array.zeroCreate (int ((writerPos + 3L) &&& ~~~3L - writerPos)): byte[])
             Debug.Assert(entry.Value <> Unchecked.defaultof<_>)
             VersionResourceSerializer.WriteVersionString(entry, writer)
 
@@ -861,7 +861,7 @@ type Win32ResourceConversions() =
             let mutable (i: uint16) = 0us
 
             while (i < count) do
-                resStream.Position <- resStream.Position + 3L &&& ~~~ 3L
+                resStream.Position <- resStream.Position + 3L &&& ~~~3L
                 resWriter.Write iconDirEntries[(int i)].dwBytesInRes
                 resWriter.Write 0x00000020u
                 resWriter.Write 0xFFFFus
@@ -878,7 +878,7 @@ type Win32ResourceConversions() =
                 i <- i + 1us
 
         let mutable (RT_GROUP_ICON: WORD) = (RT_ICON + 11us)
-        resStream.Position <- resStream.Position + 3L &&& ~~~ 3L
+        resStream.Position <- resStream.Position + 3L &&& ~~~3L
         resWriter.Write(uint32 (3 * sizeof<WORD> + int count * 14))
         resWriter.Write 0x00000020u
         resWriter.Write 0xFFFFus
@@ -933,7 +933,7 @@ type Win32ResourceConversions() =
         let comments = (defaultArg comments) Unchecked.defaultof<_>
         let companyName = (defaultArg companyName) Unchecked.defaultof<_>
         let mutable resWriter = new BinaryWriter(resStream, Encoding.Unicode)
-        resStream.Position <- resStream.Position + 3L &&& ~~~ 3L
+        resStream.Position <- resStream.Position + 3L &&& ~~~3L
         let mutable (RT_VERSION: DWORD) = 16u
 
         let mutable ver =
@@ -970,7 +970,7 @@ type Win32ResourceConversions() =
         Debug.Assert(resStream.Position - startPos = int64 dataSize + int64 headerSize)
 
     static member AppendManifestToResourceStream(resStream: Stream, manifestStream: Stream, isDll: bool) =
-        resStream.Position <- resStream.Position + 3L &&& ~~~ 3L (* ERROR UnknownPrefixOperator "~" *)
+        resStream.Position <- resStream.Position + 3L &&& ~~~3L (* ERROR UnknownPrefixOperator "~" *)
         let mutable (RT_MANIFEST: WORD) = 24us
         let mutable resWriter = new BinaryWriter(resStream)
         resWriter.Write(uint32 manifestStream.Length)

src/Compiler/AbstractIL/ilread.fs

@@ -4180,16 +4180,8 @@ and seekReadTopExportedTypes (ctxt: ILMetadataReader) =
 
 // Note, pectxtEager and pevEager must not be captured by the results of this function
 let openMetadataReader
-    (
-        fileName,
-        mdfile: BinaryFile,
-        metadataPhysLoc,
-        peinfo,
-        pectxtEager: PEReader,
-        pevEager,
-        pectxtCaptured,
-        reduceMemoryUsage
-    ) =
+    (fileName, mdfile: BinaryFile, metadataPhysLoc, peinfo, pectxtEager: PEReader, pevEager, pectxtCaptured, reduceMemoryUsage)
+    =
     let mdv = mdfile.GetView()
     let magic = seekReadUInt16AsInt32 mdv metadataPhysLoc
 

src/Compiler/AbstractIL/ilreflect.fs

@@ -290,10 +290,7 @@ type OpCode with
     member opcode.RefEmitName =
         match opcode.Name with
         | null -> ""
-        | name ->
-            (string (Char.ToUpper(name[0])) + name[1..])
-                .Replace(".", "_")
-                .Replace("_i4", "_I4")
+        | name -> (string (Char.ToUpper(name[0])) + name[1..]).Replace(".", "_").Replace("_i4", "_I4")
 
 type ILGenerator with
 
@@ -713,7 +710,7 @@ let rec convTypeSpec cenv emEnv preferCreated (tspec: ILTypeSpec) =
 
 and convTypeAux cenv emEnv preferCreated ty =
     match ty with
-    | ILType.Void -> !! Type.GetType("System.Void")
+    | ILType.Void -> !!Type.GetType("System.Void")
     | ILType.Array(shape, eltType) ->
         let baseT = convTypeAux cenv emEnv preferCreated eltType
         let nDims = shape.Rank
@@ -1491,7 +1488,7 @@ let rec emitInstr cenv (modB: ModuleBuilder) emEnv (ilG: ILGenerator) instr =
             ilG.EmitAndLog(OpCodes.Ldelema, convType cenv emEnv ty)
         else
             let arrayTy = convType cenv emEnv (ILType.Array(shape, ty))
-            let elemTy = !! arrayTy.GetElementType()
+            let elemTy = !!arrayTy.GetElementType()
             let argTys = Array.create shape.Rank typeof<int>
             let retTy = elemTy.MakeByRefType()
 
@@ -1517,7 +1514,7 @@ let rec emitInstr cenv (modB: ModuleBuilder) emEnv (ilG: ILGenerator) instr =
             ilG.EmitAndLog(OpCodes.Stelem, convType cenv emEnv ty)
         else
             let arrayTy = convType cenv emEnv (ILType.Array(shape, ty))
-            let elemTy = !! arrayTy.GetElementType()
+            let elemTy = !!arrayTy.GetElementType()
 
             let meth =
                 modB.GetArrayMethodAndLog(
@@ -2497,7 +2494,7 @@ let mkDynamicAssemblyAndModule (assemblyName: string, optimize, collectible) =
         let daType = typeof<System.Diagnostics.DebuggableAttribute>
 
         let daCtor =
-            !! daType.GetConstructor([| typeof<System.Diagnostics.DebuggableAttribute.DebuggingModes> |])
+            !!daType.GetConstructor([| typeof<System.Diagnostics.DebuggableAttribute.DebuggingModes> |])
 
         let daBuilder =
             CustomAttributeBuilder(

src/Compiler/AbstractIL/ilsupp.fs

@@ -653,8 +653,7 @@ let unlinkResource (ulLinkedResourceBaseRVA: int32) (pbLinkedResource: byte[]) =
         for i = 0 to (nResNodes - 1) do
             size <-
                 size
-                + pResNodes[i]
-                    .Save(ulLinkedResourceBaseRVA, pbLinkedResource, Unchecked.defaultof<byte[]>, 0)
+                + pResNodes[i].Save(ulLinkedResourceBaseRVA, pbLinkedResource, Unchecked.defaultof<byte[]>, 0)
 
     let pResBuffer = Bytes.zeroCreate size
 
@@ -670,7 +669,6 @@ let unlinkResource (ulLinkedResourceBaseRVA: int32) (pbLinkedResource: byte[]) =
         for i = 0 to (nResNodes - 1) do
             resBufferOffset <-
                 resBufferOffset
-                + pResNodes[i]
-                    .Save(ulLinkedResourceBaseRVA, pbLinkedResource, pResBuffer, resBufferOffset)
+                + pResNodes[i].Save(ulLinkedResourceBaseRVA, pbLinkedResource, pResBuffer, resBufferOffset)
 
     pResBuffer

src/Compiler/Checking/Expressions/CheckComputationExpressions.fs

@@ -3083,9 +3083,7 @@ let TcComputationExpression (cenv: TcFileState) env (overallTy: OverallTy) tpenv
         TranslateComputationExpression ceenv CompExprTranslationPass.Initial hasCustomOperations (LazyWithContext.NotLazy([], env)) comp id
 
     let mDelayOrQuoteOrRun =
-        mBuilderVal
-            .NoteSourceConstruct(NotedSourceConstruct.DelayOrQuoteOrRun)
-            .MakeSynthetic()
+        mBuilderVal.NoteSourceConstruct(NotedSourceConstruct.DelayOrQuoteOrRun).MakeSynthetic()
 
     // Add a call to 'Delay' if the method is present
     let delayedExpr =

src/Compiler/Checking/TailCallChecks.fs

@@ -792,7 +792,12 @@ let CheckModuleBinding cenv (isRec: bool) (TBind _ as bind) =
                     // warn for recursive calls in TryWith/TryFinally operations
                     exprs |> Seq.iter (checkTailCall true)
                 | Expr.Op(args = exprs) -> exprs |> Seq.iter (checkTailCall insideSubBindingOrTry)
-                | Expr.Sequential(expr2 = expr2) -> checkTailCall insideSubBindingOrTry expr2
+                | Expr.Sequential(expr1 = expr1; expr2 = expr2) ->
+                    match expr1 with
+                    | Expr.Op(args = exprs; op = TOp.IntegerForLoop _) -> checkTailCall insideSubBindingOrTry expr1
+                    | _ -> ()
+
+                    checkTailCall insideSubBindingOrTry expr2
                 | _ -> ()
 
             checkTailCall false bodyExpr