Skip to content

Remove unused option from performance options dialogue #14028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2022
Merged

Remove unused option from performance options dialogue #14028

merged 2 commits into from
Oct 6, 2022

Conversation

@0101
Copy link
Contributor

@0101 0101 commented Oct 5, 2022

image

This value is currently unused. It is hardcoded when FSharpChecker is created with the following comment:

projectCacheSize = 5000, // We do not care how big the cache is. VS will actually tell FCS to clear caches, so this is fine.

@vzarytovskii vzarytovskii enabled auto-merge (squash) October 5, 2022 15:13
@T-Gro T-Gro self-requested a review October 6, 2022 08:14
@vzarytovskii vzarytovskii merged commit 88e8cb3 into dotnet:main Oct 6, 2022
@allisonchou allisonchou mentioned this pull request Oct 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0101 @vzarytovskii @T-Gro