Remove Seq.toList when we already have a list #1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Might be worth investigating a lint check for those situations in the wild. |
src/fsharp/NameResolution.fs
Outdated
forki
force-pushed
the
toList
branch
2 times, most recently
from
c53291f to
c377a4b
Compare
src/fsharp/lib.fs
Outdated
Contributor
There was a problem hiding this comment.
You could just remove this function definition
Contributor
|
This is all fine. I think we can just merge it. |
Contributor
|
I like this change too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of the unification of our collections
/cc @vasily-kirichenko