WIP: with- keyword support for anonymous records
#11911
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
changed the title
with- keyword support for anonymous records
nojaf
reviewed
Aug 4, 2021
| isStruct: bool * | ||
| copyInfo:(SynExpr * BlockSeparator) option * | ||
| recordFields:(Ident * SynExpr) list * | ||
| copyInfo: (SynExpr * BlockSeparator) option * |
Contributor
There was a problem hiding this comment.
Could we have the range of the with- keyword in the tree as well?
This would be useful for Fantomas if the code has a comment after the with- for example.
type A = { X: int; Y: int }
let a = { X = 1; Y = 2 }
let b = {| a with- // foo
Y |}
Happypig375
reviewed
Aug 8, 2021
| Fsx """ | ||
| type A = { X: int } | ||
| let a = { X = 1 } | ||
| let b = {| a with- X |} |
Member
There was a problem hiding this comment.
I would expect a with- to always remove the field. When the fields already present are controlled elsewhere, I would want this to be a guarantee.
Member
There was a problem hiding this comment.
The flow of fields should allow an empty state where more fields can be added later.
Contributor
|
Closing, two years without attention, please reopen if you want to work on completiong this. Thanks Kevin |
Member
Author
|
Gonna close it for now, needs more thinking in regards of spread operator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty much a WIP or an experiment of adding a without (or
with-) keyword support for anonymous records.Note: things may change (e.g. keyword itself (as many people don't like
with-), implementation details, language switch, etc).RFC: https://github.com/fsharp/fslang-design/blob/main/RFCs/FS-1072-without-anonymous-records.md
Discussion: fsharp/fslang-design#616
Things to be done:
with-support for anonymous records expression.