-
Notifications
You must be signed in to change notification settings - Fork 840
Small fixes for chat template #5839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=938914&view=codecoverage-tab |
...ns.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/Properties/launchSettings.json
Outdated
Show resolved
Hide resolved
…t/extensions into mbuck/small-template-fixes
|
Excellent - thanks! I don't know how much difference it makes but the ASP.NET Core templates also do something to suppress these If you think it's reasonable to copy that pattern here that's great, but like I say I'm not certain what impact it has. |
Yep, seems reasonable to me 🙂 |
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=939731&view=codecoverage-tab |
Fixes some issues that unblock local development:
launchSettings.jsonfile. Without this, the environment defaults toProductionand this causes the page to fail to load when running withdotnet run.TailwindBuildtarget to always run after theBuildNpmDependenciestarget. This just required changing theAfterTargetsto aDependsOnTargets.Microsoft Reviewers: Open in CodeFlow