Skip to content

Update WaiterRemovedAfterDispose to check waitersCount first #5646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2024
+5 −2
Merged

Update WaiterRemovedAfterDispose to check waitersCount first #5646

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79a2bcb
Update WaiterRemovedAfterDispose to check waitersCount first
alechniak Nov 14, 2024
533afb4
Merge branch 'main' of https://github.com/amadeuszl/extensions into a…
alechniak Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions test/Libraries/Microsoft.Extensions.TimeProvider.Testing.Tests/TimerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,15 +226,18 @@ public void WaiterRemovedAfterDispose()

timer1.Dispose();

var waitersCountAfterDispose = timeProvider.Waiters.Count;

timeProvider.Advance(TimeSpan.FromMilliseconds(1));

var waitersCountAfter = timeProvider.Waiters.Count;
var waitersCountOnFinish = timeProvider.Waiters.Count;

Assert.Equal(0, waitersCountStart);
Assert.Equal(2, waitersCountDuring);
Assert.Equal(1, waitersCountAfterDispose);
Assert.Equal(1, waitersCountOnFinish);
Assert.Equal(1, timer1Counter);
Assert.Equal(2, timer2Counter);
Assert.Equal(1, waitersCountAfter);
}

#if RELEASE // In Release only since this might not work if the timer reference being tracked by the debugger
Expand Down
Loading