-
Notifications
You must be signed in to change notification settings - Fork 841
Publish the AotCompatibility.TestApp project as part of PR validation #5622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
002cdb7
Remove AI in Microsoft.Extensions.AI.AotCompatibility.TestApp
eerhardt 86deeab
Clean up the AotCompatibility.TestApp
eerhardt c847f9a
Make dotnet test publish the TestApp and fail if there are any warnin…
eerhardt 10fcb7b
Hook the Test target as well so the test runs in CI
eerhardt 33e95b8
Move clean logic to target.
eerhardt 9fbc27c
- Add tracing issues.
eerhardt fbf2866
Add tracking issue links for OpenAI and Azure.AI.Inference trim/AOT c…
eerhardt 5b2b7a2
Merge remote-tracking branch 'upstream/main' into AotCI
eerhardt ff0bf8c
Add an exclusion for Microsoft.Extensions.AI.Abstractions
eerhardt 12b8949
Exclude Microsoft.Extensions.AI as well, since it hits the warnings i…
eerhardt 7d554db
Cache current process object to avoid performance hit (#5597)
haipz 9c675f1
Remove cleaning from publish
eerhardt f228df9
Merge remote-tracking branch 'upstream/main' into AotCI
eerhardt 5b33969
Remove MS.Ext.AI now that the issue is resolved.
eerhardt 47beb96
Temporarily disable the test to figure out what is causing the code c…
eerhardt 0a4bbee
Revert "Temporarily disable the test to figure out what is causing th…
eerhardt e690bbf
try running during BuildAndTest.yml
eerhardt 30dae3d
Remove testing cruft from TestApp project
eerhardt 4cd0228
Change TrimmerRootAssembly to use FileName to be correct.
eerhardt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 0 additions & 26 deletions
26
...sions.AI.AotCompatibility.TestApp/Microsoft.Extensions.AI.AotCompatibility.TestApp.csproj
This file was deleted.
Oops, something went wrong.
22 changes: 0 additions & 22 deletions
22
test/Libraries/Microsoft.Extensions.AI.AotCompatibility.TestApp/Program.cs
This file was deleted.
Oops, something went wrong.
46 changes: 46 additions & 0 deletions
46
....Extensions.AotCompatibility.TestApp/Microsoft.Extensions.AotCompatibility.TestApp.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <Project> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" /> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>$(LatestTargetFramework)</TargetFramework> | ||
| <!-- clear TargetFrameworks because it is set in ..\Directory.Build.props --> | ||
| <TargetFrameworks></TargetFrameworks> | ||
| <PublishAot>true</PublishAot> | ||
| <TrimmerSingleWarn>false</TrimmerSingleWarn> | ||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <!-- Remove the ReferenceTrimmer analyzer. We explicitly want to reference every assembly so the AOT compiler sees it. --> | ||
| <PackageReference Remove="ReferenceTrimmer" /> | ||
|
|
||
| <LibraryProjects Include="$(RepoRoot)\src\Libraries\**\*.csproj" /> | ||
| <!-- https://github.com/Azure/azure-sdk-for-net/issues/47069 --> | ||
| <LibraryProjects Remove="$(RepoRoot)\src\Libraries\Microsoft.Extensions.AI.AzureAIInference\Microsoft.Extensions.AI.AzureAIInference.csproj" /> | ||
| <!-- https://github.com/openai/openai-dotnet/issues/20 --> | ||
| <LibraryProjects Remove="$(RepoRoot)\src\Libraries\Microsoft.Extensions.AI.OpenAI\Microsoft.Extensions.AI.OpenAI.csproj" /> | ||
| <!-- https://github.com/dotnet/extensions/issues/5624 --> | ||
| <LibraryProjects Remove="$(RepoRoot)\src\Libraries\Microsoft.Extensions.Caching.Hybrid\Microsoft.Extensions.Caching.Hybrid.csproj" /> | ||
| <!-- https://github.com/dotnet/extensions/issues/5623 --> | ||
| <LibraryProjects Remove="$(RepoRoot)\src\Libraries\Microsoft.Extensions.Compliance.Redaction\Microsoft.Extensions.Compliance.Redaction.csproj" /> | ||
| <!-- https://github.com/dotnet/extensions/issues/5625 --> | ||
| <!-- <LibraryProjects Remove="$(RepoRoot)\src\Libraries\Microsoft.Extensions.Http.Resilience\Microsoft.Extensions.Http.Resilience.csproj" /> --> | ||
|
|
||
| <TrimmerRootAssembly Include="@(LibraryProjects->'%(Identity)')" /> | ||
| <ProjectReference Include="@(LibraryProjects)" /> | ||
| </ItemGroup> | ||
|
|
||
| <Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk" /> | ||
|
|
||
| <Target Name="PublishProject"> | ||
| <Exec Command="$(DOTNET_HOST_PATH) publish" | ||
| WorkingDirectory="$(MSBuildProjectDirectory)" /> | ||
| </Target> | ||
|
|
||
| <!-- Override Test and VSTest so testing publishes this app and fails if there are any warnings/errors --> | ||
| <!-- Needs to be defined after importing the Sdk.targets --> | ||
| <!-- <Target Name="Test" DependsOnTargets="PublishProject" /> | ||
| <Target Name="VSTest" DependsOnTargets="Test" /> --> | ||
|
|
||
| </Project> | ||
4 changes: 4 additions & 0 deletions
4
test/Libraries/Microsoft.Extensions.AotCompatibility.TestApp/Program.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| System.Console.WriteLine("Success!"); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.