Skip to content

Added Span support to Webencoders with direct encoding #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Added Span support to Webencoders with direct encoding #338

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
637d4f9
Commits from https://github.com/aspnet/Common/pull/334
gfoidl Mar 18, 2018
355fc8b
UrlEncoder<T>.Encode and Decode added
gfoidl Apr 10, 2018
0fbee68
Encode and Decode uses UrlEncoder
gfoidl Apr 12, 2018
5b4d531
UrlCharHelper removed, is not needed anymore
gfoidl Apr 16, 2018
a08b7a5
Cleanup
gfoidl Apr 16, 2018
902e507
Code style
gfoidl Apr 16, 2018
db2297b
Included .NET Core 2.2 in multi-targeting
gfoidl Jun 19, 2018
aa41266
Rearranged the #if to make it more readable
gfoidl Jun 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions shared/Microsoft.Extensions.WebEncoders.Sources/WebEncoders.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace Microsoft.Extensions.Internal
#endif
static class WebEncoders
{
#if !NETCOREAPP2_1
#if !NETCOREAPP2_2 && !NETCOREAPP2_1
private const int MaxStackallocBytes = 256;
#endif
private const int MaxEncodedLength = (int.MaxValue / 4) * 3; // encode inflates the data by 4/3
Expand Down Expand Up @@ -251,7 +251,8 @@ public static unsafe string Base64UrlEncode(ReadOnlySpan<byte> data)

var base64Len = GetBufferSizeRequiredToBase64Encode(data.Length, out int numPaddingChars);
var base64UrlLen = base64Len - numPaddingChars;
#if NETCOREAPP2_1

#if NETCOREAPP2_2 || NETCOREAPP2_1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With dotnet/sdk#1813 this could be written cleaner.

fixed (byte* ptr = &MemoryMarshal.GetReference(data))
{
return string.Create(base64UrlLen, (Ptr: (IntPtr)ptr, data.Length), (base64Url, state) =>
Expand Down