Code coverage issues

[martintmk]

Description

In the PR #4108 I had to decrease the code-coverage from 100% to 98% because the build pipeline handles the code-coverage processing incorrectly.

The following lines:

extensions/src/Libraries/Microsoft.Extensions.Http.Resilience/FaultInjection/Internal/Log.cs

Line 16 in e70559f

public static partial void LogInjection(

extensions/src/Libraries/Microsoft.Extensions.Http.Resilience/Resilience/HttpClientBuilderExtensions.Resilience.cs

Line 31 in e70559f

public static IHttpResilienceStrategyBuilder AddResilienceHandler(

are correctly covered and tested, but the build fails.

There are also additional inconsistencies:

• Check project coverage step reports coverage of 98.46 - https://dev.azure.com/dnceng-public/public/_build/results?buildId=321876&view=logs&jobId=a7f66332-f7db-5a7e-ef2b-0455d70db552&j=a7f66332-f7db-5a7e-ef2b-0455d70db552&t=191c5785-431b-5c6c-a3e4-efe3a8133507
• Code Coverage Report reports 99.9% code coverage - https://dev.azure.com/dnceng-public/public/_build/results?buildId=321876&view=codecoverage-tab

Reproduction Steps

Increase the min coverage to 100, the build fails:

extensions/src/Libraries/Microsoft.Extensions.Http.Resilience/Microsoft.Extensions.Http.Resilience.csproj

Line 22 in 6d67b41

<MinCodeCoverage>99</MinCodeCoverage>

Expected behavior

Increase the min coverage to 100, the build should succeed:

extensions/src/Libraries/Microsoft.Extensions.Http.Resilience/Microsoft.Extensions.Http.Resilience.csproj

Line 22 in 6d67b41

<MinCodeCoverage>99</MinCodeCoverage>

Actual behavior

The build fails when increasing the code-coverage to 100

extensions/src/Libraries/Microsoft.Extensions.Http.Resilience/Microsoft.Extensions.Http.Resilience.csproj

Line 22 in 6d67b41

<MinCodeCoverage>99</MinCodeCoverage>

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

Please

[RussKie]

As per recommendation we need to use PublishCodeCoverageResults@2 task. However, that task is currently broken.
I was advised the fix is in the pipeline, however, I'm yet to get clearer information on when the fix will be public.

/cc: @vinayakmsft

[RussKie]

@vinayakmsft advised me yesterday that it may be few weeks before the fix will be rolled out. In the interim as a workaround we can run the task on Windows agents and install .NET 7.

[geeknoid]

Is this fixed?

[RussKie]

No, PublishCodeCoverageResults@2 is still unusable, we're stuck with v1.

Related:

• [BUG]: PublishCodeCoverageResults@2 result pane not as useful as PublishCodeCoverageResults@1  microsoft/azure-pipelines-tasks#19939
• [BUG]: PublishCodeCoverageResults@2 incorrect coverage reports microsoft/azure-pipelines-tasks#20882
• [BUG]: Inconsistency in displaying code coverage with PublishCodeCoverageResults microsoft/azure-pipelines-tasks#19221