Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Feb 10, 2025

This pull request updates the following dependencies

From https://github.com/dotnet/extensions

  • Subscription: 80debde5-c49b-4a86-8145-3a9b9d7f5f82
  • Build: 20250217.3
  • Date Produced: February 17, 2025 1:44:28 PM UTC
  • Commit: c2c1abc4bc96e1ebbf19faafcf5a7b28f6c81e8b
  • Branch: refs/heads/main

…0250207.9

Microsoft.AspNetCore.Diagnostics.Middleware , Microsoft.Extensions.AuditReports , Microsoft.Extensions.Compliance.Abstractions , Microsoft.Extensions.Compliance.Redaction , Microsoft.Extensions.Compliance.Testing , Microsoft.Extensions.Diagnostics.ExceptionSummarization , Microsoft.Extensions.Diagnostics.Testing , Microsoft.Extensions.Http.Diagnostics , Microsoft.Extensions.Telemetry , Microsoft.Extensions.Telemetry.Abstractions
 From Version 9.2.0-preview.1.25076.1 -> To Version 9.3.0-preview.1.25107.9
Copy link

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@RussKie
Copy link
Contributor

RussKie commented Feb 13, 2025

@dotnet/dotnet-extensions-compliance can you please have a look at the failure here.

 error NU1101: Unable to find package Microsoft.Gen.MetadataExtractor. No packages exist with this id in source(s): dotnet-eng, dotnet-public, dotnet9, dotnet9-transport, richnav

We have never published Microsoft.Gen.MetadataExtractor package, and until recently it wasn't needed. Now it is....

@RussKie
Copy link
Contributor

RussKie commented Feb 13, 2025

Looks like the regression is caused by dotnet/extensions#5531

@dariusclay
Copy link
Member

This breaks anyone that would use the AuditReports or MetricReports extensions since they will not be able to resolve the dependency on Microsoft.Gen.MetadataExtractor. It's being referenced directly as a ProjectReference, not an AnalyzerReference.

@dariusclay
Copy link
Member

Opened dotnet/extensions#5894 to fix the issue (hopefully)

…0250214.10

Microsoft.AspNetCore.Diagnostics.Middleware , Microsoft.Extensions.AuditReports , Microsoft.Extensions.Compliance.Abstractions , Microsoft.Extensions.Compliance.Redaction , Microsoft.Extensions.Compliance.Testing , Microsoft.Extensions.Diagnostics.ExceptionSummarization , Microsoft.Extensions.Diagnostics.Testing , Microsoft.Extensions.Http.Diagnostics , Microsoft.Extensions.Telemetry , Microsoft.Extensions.Telemetry.Abstractions
 From Version 9.2.0-preview.1.25076.1 -> To Version 9.3.0-preview.1.25114.10
@RussKie
Copy link
Contributor

RussKie commented Feb 17, 2025

…0250216.2

Microsoft.AspNetCore.Diagnostics.Middleware , Microsoft.Extensions.AuditReports , Microsoft.Extensions.Compliance.Abstractions , Microsoft.Extensions.Compliance.Redaction , Microsoft.Extensions.Compliance.Testing , Microsoft.Extensions.Diagnostics.ExceptionSummarization , Microsoft.Extensions.Diagnostics.Testing , Microsoft.Extensions.Http.Diagnostics , Microsoft.Extensions.Telemetry , Microsoft.Extensions.Telemetry.Abstractions
 From Version 9.2.0-preview.1.25076.1 -> To Version 9.3.0-preview.1.25116.2
@dariusclay
Copy link
Member

Ack. Taking a look

@dariusclay
Copy link
Member

@dariusclay @evgenyfedorov2 @IbrahimMNada It doesn't look like the fix worked --> https://dev.azure.com/dnceng-public/public/_build/results?buildId=954044&view=logs&j=9db12f06-3bef-52cb-1e93-45aadd48533c&t=ec5978c4-c627-5e9c-2f03-d0f13ef24719&l=187

The problem here is that Microsoft.Gen.MetadataExtractor is pulling in more than it needs from Microsoft.Gen.Metrics, causing a duplicate generator. I will push a fix for this ASAP.

@dariusclay
Copy link
Member

How do we trigger the update? I cannot find it in the workflows.

…0250217.3

Microsoft.AspNetCore.Diagnostics.Middleware , Microsoft.Extensions.AuditReports , Microsoft.Extensions.Compliance.Abstractions , Microsoft.Extensions.Compliance.Redaction , Microsoft.Extensions.Compliance.Testing , Microsoft.Extensions.Diagnostics.ExceptionSummarization , Microsoft.Extensions.Diagnostics.Testing , Microsoft.Extensions.Http.Diagnostics , Microsoft.Extensions.Telemetry , Microsoft.Extensions.Telemetry.Abstractions
 From Version 9.2.0-preview.1.25076.1 -> To Version 9.3.0-preview.1.25117.3
@RussKie
Copy link
Contributor

RussKie commented Feb 18, 2025

How do we trigger the update? I cannot find it in the workflows.

The default workflow is whenever dotent/extensions main is published to a transport feed (as a result of the successful internal build), it gets pushed here based on a schedule. Previously the schedule was set to "weekly" and I just changed to "daily". That is, once a day the latest build artifacts from dotnet/extensions will get pushed to this repo. There are ways to trigger the inflow manually with darc trigger-subscriptions command:

darc trigger-subscriptions --id 80debde5-c49b-4a86-8145-3a9b9d7f5f82

@RussKie RussKie merged commit b225d09 into main Feb 18, 2025
4 checks passed
@RussKie RussKie deleted the darc-main-f9fac21d-5abc-4d20-b047-7190808958f1 branch February 18, 2025 00:24
@RussKie
Copy link
Contributor

RussKie commented Feb 18, 2025

Looks like we're good! Thank you @dariusclay for getting it fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants