Fix NullReferenceException in SqlServerAnnotationCodeGenerator when scaffolding columns with named default constraints and CLR default values #37243
+31
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #37175
Scaffolding fails with
NullReferenceExceptionwhen a column has both a named default constraint and a default value equal to the CLR default (e.g.,DEFAULT ((0))forint).Root cause:
SqlServerAnnotationCodeGenerator.GenerateFluentApiCallsassumed that ifDefaultConstraintNameexists, eitherDefaultValueorDefaultValueSqlmust also exist. However, the base scaffolding logic inScaffoldingModelExtensions.GenerateAnnotationscan remove these annotations when the default value equals the CLR default, leaving onlyDefaultConstraintName.Fix: Changed the
Check.DebugAssertto a conditionalelse ifcheck. When neitherDefaultValuenorDefaultValueSqlexists, skip generating code for the constraint name instead of throwing.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.