Fallback to OPENJSON with many parameters #37234
Draft
+223
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
reviewed
Nov 25, 2025
| { | ||
| switch (node) | ||
| { | ||
| case ValuesExpression valuesExpression when valuesExpression.ValuesParameter is { } valuesParameter: |
Member
There was a problem hiding this comment.
nit:
Suggested change
| case ValuesExpression valuesExpression when valuesExpression.ValuesParameter is { } valuesParameter: | |
| case ValuesExpression { ValuesParameter: { } valuesParameter }: |
(and below)
| } | ||
| else | ||
| { | ||
| ProcessParameter(sqlParameterExpression); |
Member
There was a problem hiding this comment.
I think we also need to take Constants mode into account no? In that case the parameter shouldn't be counted at all (since its contents are fully inlined)
| private readonly ISqlServerSingletonOptions _sqlServerSingletonOptions; | ||
|
|
||
| private int _openJsonAliasCounter; | ||
| private int _parametersCount; |
Member
There was a problem hiding this comment.
Suggested change
| private int _parametersCount; | |
| private int _totalParameterCount; |
| Count += count; | ||
| if (bucketization) | ||
| { | ||
| var elementTypeMapping = (RelationalTypeMapping)sqlParameterExpression.TypeMapping!.ElementTypeMapping!; |
Member
There was a problem hiding this comment.
Remind me - we need the type mapping just in case the padding/bucketization needs to work differently depending on the parameter type (e.g. bucketize on int but not on big varbinary)? If so, we don't actually currently do that, do we?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37185.