[release/10.0] Fix HasJsonPropertyName for complex properties

[Copilot]

Fixes #37009
Port of #37019

Description

The issue was that HasJsonPropertyName() configuration on complex properties and complex collections within JSON columns was not working correctly because the annotation was being stored on the complex property instead of the complex type. This wasn't consistent with the way owned entity types are configured and wasn't expected by the query pipeline, which caused the reported issue.

Customer Impact

Apps with custom JSON property names on complex properties or complex collections within JSON columns using will throw an exception or return invalid data. This is a common scenario for developers that choose to map JSON columns as complex types and this is the recommended way of doing it starting with EF 10.
A workaround is to use .HasTypeAnnotation(RelationalAnnotationNames.JsonPropertyName, name)

How found

Reported on 10.0.0-rc2

Regression

No, this is a new feature

Testing

Test added

Risk

Low - The changes are surgical and focused on JSON property name configuration handling for complex types. The annotation code generator now correctly generates HasJsonPropertyName() from both complex type and complex property annotations to support the backward compatibility quirk. Quirk added for backward compatibility.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[AndriySvyryd]

@copilot Also add code to AnnotationCodeGenerator. GenerateFluentApiCalls(IComplexType,IDictionary<string, IAnnotation>) to handle the JsonPropertyName annotation. Verify by running Complex_types_mapped_to_json_are_stored_in_snapshot test

[Copilot]

@copilot Also add code to AnnotationCodeGenerator. GenerateFluentApiCalls(IComplexType,IDictionary<string, IAnnotation>) to handle the JsonPropertyName annotation. Verify by running Complex_types_mapp...

Done in 2909659. Added GenerateSimpleFluentApiCall for JsonPropertyName to the GenerateFluentApiCalls(IComplexType) method and removed it from the GenerateFluentApiCalls(IComplexProperty) method, so the annotation is now generated from the complex type where it's stored.

[roji]

LGTM. Am just not sure what the branch release/10.0 means at this stage - should we be targeting 10.0-staging as usual?

[AndriySvyryd]

There's no release/10.0-staging yet

[SamMonoRT]

Removing servicing consider label till all reviews/checks/CI is green. Please add it back when ready.

[AndriySvyryd]

The failure was unrelated, fixed in #37022