Locate C++ toolchain path dynamically #1390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am11
commented
Mar 12, 2025
akoeplinger
approved these changes
Mar 12, 2025
am11
force-pushed
the
feature/dynamic-c++-toolchain
branch
from
23e9442 to
4d315b7
Compare
akoeplinger
requested changes
Mar 12, 2025
am11
force-pushed
the
feature/dynamic-c++-toolchain
branch
3 times, most recently
from
5b7818f to
5216919
Compare
am11
force-pushed
the
feature/dynamic-c++-toolchain
branch
from
5216919 to
f998615
Compare
akoeplinger
reviewed
Mar 12, 2025
akoeplinger
approved these changes
Mar 12, 2025
mthalman
approved these changes
Mar 12, 2025
auto-merge was automatically disabled
March 12, 2025 18:37
Head branch was pushed to by a user without write access
am11
force-pushed
the
feature/dynamic-c++-toolchain
branch
from
8ff659e to
758402f
Compare
am11
force-pushed
the
feature/dynamic-c++-toolchain
branch
from
bed75a0 to
1b9fd30
Compare
Member
Author
|
This is ready. |
akoeplinger
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding them, use a dynamic lookup to avoid manual upkeep #1162.
ps - ideally we should extract this step into a script file; single source of truth.