Skip to content

Remove irrelevant section from trimming docs #24962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Jul 1, 2021

This looks like someone was documenting a workaround for trimming issues
they encountered in previous versions: dotnet/runtime#44260

It doesn't belong in these docs, and the analysis warnings
should prevent such issues going forward.

Thanks to @eerhardt for noticing this!

This looks like someone was documenting a workaround for trimming issues
they encountered in previous versions: dotnet/runtime#44260

It doesn't belong in these docs, and the analysis warnings
should prevent such issues going forward.
@sbomer sbomer requested a review from adegeo as a code owner July 1, 2021 22:14
@dotnet-bot dotnet-bot added this to the July 2021 milestone Jul 1, 2021
@sbomer sbomer requested a review from BillWagner as a code owner July 1, 2021 22:17
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sbomer sbomer force-pushed the removeTrimSection branch from f679fef to 6a7c729 Compare July 1, 2021 22:21
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

I'll :shipit: now.

@BillWagner
Copy link
Member

closing and reopening to start a new build.

@BillWagner BillWagner closed this Jul 2, 2021
@BillWagner BillWagner reopened this Jul 2, 2021
@BillWagner BillWagner enabled auto-merge July 2, 2021 14:49
@BillWagner BillWagner merged commit 5ffe73f into dotnet:main Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants