Skip to content

Info on when counters were first introduced #24956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 2, 2021
Merged

Info on when counters were first introduced #24956

merged 3 commits into from
Jul 2, 2021

Conversation

shirhatti
Copy link
Contributor

No description provided.

@shirhatti shirhatti requested review from sdmaclea, tommcdon and a team as code owners July 1, 2021 17:49
@dotnet-bot dotnet-bot added this to the July 2021 milestone Jul 1, 2021
@shirhatti
Copy link
Contributor Author

Still need to fill in the remaining counters
👀 @josalem

@josalem josalem mentioned this pull request Jul 1, 2021
Closed
26 tasks
@josalem
Copy link
Contributor

josalem commented Jul 1, 2021

There are some counters in that doc that specify version dependencies in the description of the counter, see line 110 in the doc. We should be consistent in how we specify this requirement. One other consideration: we should differentiate between AspNet v3.1 and .net3.1 since you can run AspNet 2.1/2.2 on top of .net3.1 right?

@shirhatti
Copy link
Contributor Author

We should be consistent in how we specify this requirement.

Sure. I'll update everything to the new format

One other consideration: we should differentiate between AspNet v3.1 and .net3.1 since you can run AspNet 2.1/2.2 on top of .net3.1 right?

I don't think it's worth going into that level in detail. Especially given that the only supported scenario is running ASP.NET Core 2.1 on .NET Fx. If you're running ASP.NET Core 2.1 on .NET Core 3.1, you're already in unsupported territory

@josalem
Copy link
Contributor

josalem commented Jul 1, 2021

Works for me 😃

BillWagner
BillWagner reviewed Jul 2, 2021
View reviewed changes
BillWagner
BillWagner approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

I'll :shipit: now.

@BillWagner BillWagner enabled auto-merge (squash) July 2, 2021 14:48
@BillWagner BillWagner merged commit 955bf2c into main Jul 2, 2021
@BillWagner BillWagner deleted the shirhatti/countersinfo branch July 2, 2021 14:56
Youssef1313 pushed a commit to Youssef1313/docs that referenced this pull request Jul 5, 2021
@shirhatti @BillWagner @Youssef1313
Info on when counters were first introduced (dotnet#24956)
9065b26 
* Info on when counters were first introduced

* Update available-counters.md

* Update docs/core/diagnostics/available-counters.md

Co-authored-by: Bill Wagner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@sdmaclea sdmaclea Awaiting requested review from sdmaclea

@tommcdon tommcdon Awaiting requested review from tommcdon tommcdon is a code owner

+1 more reviewer

@josalem josalem josalem approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
July 2021
Development

Successfully merging this pull request may close these issues.
4 participants
@shirhatti @josalem @BillWagner @dotnet-bot