Skip to content

frequently-asked-questions.md converted into YML #24870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 6, 2021

Conversation

v-hearya
Copy link
Contributor

@v-hearya v-hearya commented Jun 25, 2021

Per the this page, Updated following Markdown to YAML template, to improve the discoverability of the FAQ pages in Google.

@IEvangelist
Copy link
Member

Attention: @Youssef1313 -- seeing build verifier failure here, not sure why?

@Youssef1313
Copy link
Member

@IEvangelist You can safely ignore this failure for now (the build won't fail on subsequent PRs). This is a case where a deleted file doesn't need a redirection that I'm not handling. I opened dotnet/docs-tools#12 to track fixing this.

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues with the includes...

image

image

- question: |
How long does my database connection remain open?
answer: |
A connection typically remains open until you consume the query results. If you expect to take time to process all the results and are not opposed to caching the results, apply <xref:System.Linq.Enumerable.ToList%2A> to the query. In common scenarios where each object is processed only one time, the streaming model is superior in both `DataReader` and [!INCLUDE[vbtecdlinq](../../../../../../includes/vbtecdlinq-md.md)].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This [!INCLUDE] is not rendering correctly, I do not believe the that YML supports the include syntax like MD files do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under Question [!INCLUDE] doesn't support. We can use it in Answer or summary.

- name: SQL-Injection Attacks
questions:
- question: |
How is [!INCLUDE[vbtecdlinq](../../../../../../includes/vbtecdlinq-md.md)] protected from SQL-injection attacks?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
How is [!INCLUDE[vbtecdlinq](../../../../../../includes/vbtecdlinq-md.md)] protected from SQL-injection attacks?
How is LINQ to SQL protected from SQL-injection attacks?

We should replace ALL occurrences of [!INCLUDE[vbtecdlinq](../../../../../../includes/vbtecdlinq-md.md)] with LINQ to SQL.

v-hearya and others added 2 commits July 3, 2021 03:55
[!INCLUDE[vbtecdlinq](../../../../../../includes/vbtecdlinq-md.md)] replaced with LINQ to SQ in Questions only as they don't support [!INCLUDE].
@v-hearya
Copy link
Contributor Author

v-hearya commented Jul 2, 2021

@IEvangelist - Needed changes made, please verify.

@IEvangelist IEvangelist merged commit c9a92fc into dotnet:main Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants