Skip to content

Fix text that was causing translation error #21749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Conversation

tdykstra
Copy link
Contributor

@dotnet-bot dotnet-bot added this to the December 2020 milestone Nov 29, 2020
@tdykstra tdykstra requested review from mamccrea and IEvangelist and removed request for mamccrea November 29, 2020 20:16
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit: when you're ready.

@tdykstra tdykstra merged commit 30fef5b into live Dec 3, 2020
@tdykstra tdykstra deleted the tdykstra-patch-1 branch December 3, 2020 16:39
@Youssef1313
Copy link
Member

@tdykstra @IEvangelist Was this intended to be merged into live directly? The change doesn't exist in current main.

@IEvangelist
Copy link
Member

@tdykstra @IEvangelist Was this intended to be merged into live directly? The change doesn't exist in current main.

Hi @Youssef1313 - that is a great observation. I'm not actually sure, @tdykstra do you know - if not we should sync this?

@Youssef1313
Copy link
Member

Pinging @tdykstra (there is #20476 as well).

@tdykstra
Copy link
Contributor Author

tdykstra commented Jul 6, 2021

Yes this was accidentally merged directly to live-- @BillWagner I think the best thing to do here is revert the PR and redo the change in a PR to main -- do you have a better idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants