Skip to content

Conversation

@Youssef1313
Copy link
Member

Fixes #15632

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion but I'd like to ping to review this one because he originally wrote this article with the two different titles so not sure if there was any intention behind that.

@mairaw mairaw requested a review from BillWagner November 21, 2019 06:06
@mairaw
Copy link
Contributor

mairaw commented Nov 21, 2019

We might also have to make further updates and keep the title as security analyzer or FxCop analyzers since the https://www.nuget.org/packages/Microsoft.CodeAnalysis.FxCopAnalyzers/ package now also contains a Core version.

@BillWagner
Copy link
Member

Adding @mikadumont for the correct name of this set of packages going forward.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got confirmation that this is the correct naming going forward. I'll :shipit: now.

Thanks again @Youssef1313

@BillWagner
Copy link
Member

I'm going to close and reopen to get a fresh build.

@BillWagner BillWagner closed this Nov 21, 2019
@BillWagner BillWagner reopened this Nov 21, 2019
@BillWagner BillWagner merged commit cf82995 into dotnet:master Nov 21, 2019
@Youssef1313 Youssef1313 deleted the patch-1 branch November 21, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Title of Page - The .NET Framework Analyzer or The .NET Security Analyzers

4 participants