Skip to content

Conversation

@IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Feb 7, 2025

Summary

Rewrite Azure Key Vault content.

Fixes #2311


Internal previews

📄 File 🔗 Preview link
docs/security/azure-security-key-vault-integration.md .NET Aspire Azure Key Vault integration

@dotnetrepoman dotnetrepoman bot added database Content related to database. security Content related to security. labels Feb 7, 2025
@dotnet-policy-service dotnet-policy-service bot added the okr-freshness OKR: Freshness of content label Feb 7, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (4)

docs/security/azure-security-key-vault-integration.md:3

  • The word 'Lean' should be 'Learn'.
description: Lean about the .NET Aspire Azure Key Vault integration.

docs/security/azure-security-key-vault-integration.md:33

  • The word 'THe' should be 'The'.
THe following sections describe various example usages.

docs/security/azure-security-key-vault-integration.md:188

  • [nitpick] The term ':::no-loc text="Program.cs":::' should be consistent with the rest of the document.
In the :::no-loc text="Program.cs"::: file of your client-consuming project, call the <xref:Microsoft.Extensions.Hosting.AspireKeyVaultExtensions.AddAzureKeyVaultSecrets*> extension method on the <xref:Microsoft.Extensions.Configuration.IConfiguration> to add the secrets as part of your app's configuration.

docs/security/azure-security-key-vault-integration.md:194

  • [nitpick] The note about AddAzureKeyVaultSecrets API name causing confusion should be clearer.
> [!NOTE]
> The `AddAzureKeyVaultSecrets` API name has caused a bit of confusion. The method is used to configure the `SecretClient` based on the given connection name, and _it's not used_ to add secrets to the configuration.

Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a few suggestions for you to consider.

@IEvangelist IEvangelist merged commit 212a101 into dotnet:main Feb 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

database Content related to database. okr-freshness OKR: Freshness of content security Content related to security.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewrite of the Azure Key Vault integration article

2 participants