-
Notifications
You must be signed in to change notification settings - Fork 168
Rewrite Azure Key Vault content #2555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (4)
docs/security/azure-security-key-vault-integration.md:3
- The word 'Lean' should be 'Learn'.
description: Lean about the .NET Aspire Azure Key Vault integration.
docs/security/azure-security-key-vault-integration.md:33
- The word 'THe' should be 'The'.
THe following sections describe various example usages.
docs/security/azure-security-key-vault-integration.md:188
- [nitpick] The term ':::no-loc text="Program.cs":::' should be consistent with the rest of the document.
In the :::no-loc text="Program.cs"::: file of your client-consuming project, call the <xref:Microsoft.Extensions.Hosting.AspireKeyVaultExtensions.AddAzureKeyVaultSecrets*> extension method on the <xref:Microsoft.Extensions.Configuration.IConfiguration> to add the secrets as part of your app's configuration.
docs/security/azure-security-key-vault-integration.md:194
- [nitpick] The note about
AddAzureKeyVaultSecretsAPI name causing confusion should be clearer.
> [!NOTE]
> The `AddAzureKeyVaultSecrets` API name has caused a bit of confusion. The method is used to configure the `SecretClient` based on the given connection name, and _it's not used_ to add secrets to the configuration.
Co-authored-by: Copilot <[email protected]>
4b0451f to
a0fe879
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left a few suggestions for you to consider.
Co-authored-by: Tom Dykstra <[email protected]>
Summary
Rewrite Azure Key Vault content.
Fixes #2311
Internal previews