-
Notifications
You must be signed in to change notification settings - Fork 383
[cDAC] Add support to run SOS tests against the cDAC #5350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| <ItemGroup> | ||
| <_LiveRuntimeFiles Include="$(LiveRuntimeDir)\**\*.*" /> | ||
| </ItemGroup> | ||
| <Copy SourceFiles="@(_LiveRuntimeFiles)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the time this will work but there can be up to 3 versions of the latest (10) runtime in the .dotnet-test directory
- The version installed with the test .NET 10 SDK
- The version installed with the aspnetcore latest
- The runtime version installed explicitly from the DARC update which is (the MicrosoftNETCoreAppRuntimewinx64Version property) that the $(DotNetInstallDir) is built from.
That is why I didn't automate the private build copying in the instructions. If you only copy #3, then most of the tests will run on that version except the couple of aspnetcore debuggee's (WebApp3, etc.). For the couple of cdac specific tests you created this is sufficient, but for all the tests run to test the cdac private build, the aspnetcore runtime would also need to be copied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of growing what we have to override with the cdac. After this change it'll be easier to hook up a pipeline that runtime can use to validate cdac changes against this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Left one comment. I'll leave it to you to decide if any changes are neccesary.
Follow up to dotnet#5350 that adds the ability to use the cdac and patch a local copy of the shared framework on non-windows hosts.
Follow up to #5350 that adds the ability to use the cdac and patch a local copy of the shared framework on non-windows hosts. --------- Co-authored-by: kasperk81 <[email protected]>
dotnet/runtime#110758
Given the cDAC only supports a small subset of the DAC apis, I have created some pared down tests that are
CDACCompatible.Steps to run tests with cDAC:
eng\privatebuild.cmdin the diagnostics repo.\dotnet-test. See https://github.com/dotnet/diagnostics/blob/main/documentation/privatebuildtesting.md for example.Note, with the addition of the cDAC,
cdacreader.dlland all of the dll's undercdaclibsmust be copied over as well.eng\testsoscdac.cmdin the diagnostics repo.The cDAC can be debugged in these tests by running the tests script with
$env:VSTEST_HOST_DEBUG=1which waits for a debugger to attach to the test host. Use VS with the Child Process Debugging Power Tool to selectively debugcdb.exechild process. Note this requires using mixed mode debugging.