This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Use the GC provided environments instead of the PAL ones #7596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suchiman
commented
Jul 7, 2019
Suchiman
commented
Jul 7, 2019
Suchiman
commented
Jul 7, 2019
Suchiman
commented
Jul 7, 2019
Suchiman
commented
Jul 7, 2019
welp 😄 |
jkotas
approved these changes
Jul 7, 2019
|
|
||
| list(APPEND COMMON_RUNTIME_SOURCES | ||
| unix/PalRedhawkUnix.cpp | ||
| ../gc/unix/gcenv.unix.cpp |
There was a problem hiding this comment.
I have noticed that gcenv.unix.cpp has several TODOs.
In particular, GCToOSInterface::GetCacheSizePerLogicalCpu is important for a good GC performance. It was not implemented for CoreRT before your change either, so it is not a regression. I would be nice to get it fixed in future change.
|
I was just looking at the |
|
It is fallback path for 32-bit x86 only that should not be needed at all, but Maoni was reluctant to delete it: dotnet/coreclr#22180 (comment) |
jkotas
added a commit
to jkotas/coreclr
that referenced
this pull request
Jul 12, 2019
Port dotnet/corert#7596 to CoreCLR
jkotas
added a commit
to jkotas/coreclr
that referenced
this pull request
Jul 12, 2019
Port dotnet/corert#7596 to CoreCLR
jkotas
added a commit
to jkotas/coreclr
that referenced
this pull request
Jul 12, 2019
Port dotnet/corert#7596 to CoreCLR
jkotas
added a commit
to dotnet/coreclr
that referenced
this pull request
Jul 17, 2019
* Rename GC's config.h to avoid name collisions Port dotnet/corert#7596 to CoreCLR * Fix build break
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 3/6 from #7339