Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Aug 19, 2019

This reverts commit 176da26.

@omajid this broke the testing scenario as the ArchGroup defaults to x86 after this change. will revert this to unblock others and we can work on a follow-up change.

Discovered in https://github.com/dotnet/corefx/issues/40052#issuecomment-522498432

cc @Gnbrkm41 @Wraith2 @steveharter

@omajid
Copy link
Member

omajid commented Aug 19, 2019

Thanks for the quick fix. Any ideas on how CI could have caught this?

@joperezr
Copy link
Member

We've had more internal reports of this @ViktorHofer so please do go ahead and merge this when you are ready.

@joperezr
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 3 pipeline(s).

@joperezr
Copy link
Member

@ViktorHofer FYI seems like your latest change to outerloop.yml broke the outerloop test run according to the above message. It is not blocking but I suppose you will want to either revert that or fix it as well.

@ViktorHofer ViktorHofer merged commit 0e2dc47 into dotnet:master Aug 20, 2019
@ViktorHofer ViktorHofer deleted the revertRID branch August 20, 2019 04:55
@ViktorHofer
Copy link
Member Author

@joperezr anybreason why you triggered the Outerloop legs here? Yeah I'm trying out a fix right now. Thanks for letting me know.

@joperezr
Copy link
Member

anybreason why you triggered the Outerloop legs here?

Your builds were cancelled and I wasn't able to retry them on the AzDO side, so I ran the /azp run command from here to run everything, which also triggers the outerloop runs.

@ViktorHofer
Copy link
Member Author

For that you want to use the /azp run corefx-ci command. The /azp run command triggers everything.

@karelz karelz added this to the 5.0 milestone Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants