This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add spec for writable JSON DOM #39954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* specification consisting of following sections added: - introduction - goals - todos - example scenarios - design choices - implementation details - open questions - useful links * review comments included
bartonjs
reviewed
Aug 1, 2019
bartonjs
reviewed
Aug 1, 2019
JamesNK
reviewed
Aug 1, 2019
Member
|
@ViktorHofer, this PR only adds/touches a .md file. Why did CI run? |
ahsonkhan
added
the
documentation
Member
@stephentoub currently wildcards in the exclude filter only works at the end: https://github.com/MicrosoftDocs/vsts-docs/issues/2363#issuecomment-444224630. We are waiting for refined exclude filters. Means the second filter here currently doesn't work: https://github.com/dotnet/corefx/blob/master/.azure-ci.yml#L21-L24 |
ahsonkhan
approved these changes
Aug 7, 2019
ahsonkhan
left a comment
ahsonkhan
left a comment
There was a problem hiding this comment.
Some leftover feedback, points of discussion. Overall, LGTM.
Member
|
What should ToString return - #40107 (comment) |
ahsonkhan
reviewed
Aug 8, 2019
ahsonkhan
reviewed
Aug 8, 2019
ahsonkhan
reviewed
Aug 8, 2019
ahsonkhan
reviewed
Aug 8, 2019
ahsonkhan
reviewed
Aug 8, 2019
ahsonkhan
approved these changes
Aug 9, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Specification (dotnet/corefx#4) * specification consisting of following sections added: - introduction - goals - todos - example scenarios - design choices - implementation details - open questions - useful links * review comments included Commit migrated from dotnet/corefx@7ec3954
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added specification consisting of following sections:
Continuation of kasiabulat#4
Issue: #39922
cc: @joperezr @bartonjs @ericstj @ahsonkhan @terrajobst @JamesNK