This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Handle concurrent dispose and WriteAsync calls #36988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lock the entire Write operation - Added a test that Completes both reader and writer in the middle of writing a large buffer
benaadams
approved these changes
Apr 18, 2019
Member
|
Still think TestHost.ResponseStream also needs fixing so you can't call write and complete at the same time on different threads. |
Member
Author
Yep. Looking at that. |
jkotalik
reviewed
Apr 18, 2019
| { | ||
| for (int i = 0; i < 1000; i++) | ||
| { | ||
| var buffer = new byte[10000000]; |
There was a problem hiding this comment.
Nit: Allocate this array outside of the try.
jkotalik
reviewed
Apr 18, 2019
| { | ||
| // This is the multi segment copy | ||
| WriteMultiSegment(source.Span); | ||
| } |
There was a problem hiding this comment.
Is there any concern of acquiring and releasing the lock immediately between here and FlushAsync? Can a call interleave in here that would affect the write call? I doubt it, but it's the only cause for concern I see.
Member
Author
There was a problem hiding this comment.
Should be fine. Efficiency.
jkotalik
approved these changes
Apr 18, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
- lock the entire Write operation - Added a test that Completes both reader and writer in the middle of writing a large buffer Commit migrated from dotnet/corefx@90d98b9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @benaadams
Found in ASP.NET Core test