This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix ClientWebSocket closing handshake logic #36975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An HttpListener websocket test was failing after the change from PR dotnet#36928. That PR made changes to tighten up the transition to the Closed state after the closing handshake had completed. That PR missed some additional changes needed especially in cases where a server (such as loopback) sends the close frame almost concurrently with the client sending the close frame. This PR fixes the close frame handshake logic and also makes some optimizations in cases where the websocket has already transitioned to the Aborted state during the closing handshake. In that case, the websocket should not wait for a close frame to be received but should simply proceed to closing the connection. Fixes #36963
Contributor
Author
|
/azp run corefx-outerloop-windows |
Contributor
Author
|
/azp run corefx-outerloop-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run corefx-outerloop-osx |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephentoub
approved these changes
Apr 18, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
An HttpListener websocket test was failing after the change from PR dotnet/corefx#36928. That PR made changes to tighten up the transition to the Closed state after the closing handshake had completed. That PR missed some additional changes needed especially in cases where a server (such as loopback) sends the close frame almost concurrently with the client sending the close frame. This PR fixes the close frame handshake logic and also makes some optimizations in cases where the websocket has already transitioned to the Aborted state during the closing handshake. In that case, the websocket should not wait for a close frame to be received but should simply proceed to closing the connection. Fixes dotnet/corefx#36963 Commit migrated from dotnet/corefx@1824535
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An HttpListener websocket test was failing after the change from PR #36928. That PR made changes
to tighten up the transition to the Closed state after the closing handshake had completed.
That PR missed some additional changes needed especially in cases where a server (such as loopback)
sends the close frame almost concurrently with the client sending the close frame.
This PR fixes the close frame handshake logic and also makes some optimizations in cases where the
websocket has already transitioned to the Aborted state during the closing handshake. In that case,
the websocket should not wait for a close frame to be received but should simply proceed to closing
the connection.
Fixes #36963