This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add unit tests for UTF-8 transcoding logic #36712
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
approved these changes
Apr 8, 2019
tarekgh
approved these changes
Apr 8, 2019
Contributor
|
SRM test changes look fine to me. |
stephentoub
approved these changes
Apr 8, 2019
…0411.72 - Microsoft.NET.Sdk.IL - 3.0.0-preview5-27611-72 - Microsoft.NETCore.ILAsm - 3.0.0-preview5-27611-72 - Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27611-72
…0412.73 - Microsoft.NET.Sdk.IL - 3.0.0-preview5-27612-73 - Microsoft.NETCore.ILAsm - 3.0.0-preview5-27612-73 - Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27612-73
This was referenced Apr 13, 2019
…92e-3254c6a2061a' into encoding_test_fixups
GrabYourPitchforks
added a commit
that referenced
this pull request
Apr 13, 2019
GrabYourPitchforks
pushed a commit
that referenced
this pull request
Apr 13, 2019
- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27612-73 - Microsoft.NETCore.ILAsm - 3.0.0-preview5-27612-73 - Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27612-73 - Also react to changes in the UTF-8 transcoding logic (#36712)
Member
Author
|
This went in as part of #36816. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27612-73 - Microsoft.NETCore.ILAsm - 3.0.0-preview5-27612-73 - Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27612-73 - Also react to changes in the UTF-8 transcoding logic (dotnet/corefx#36712) Commit migrated from dotnet/corefx@4c3d4a0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the unit tests for dotnet/coreclr#21948. It's mainly adding new tests / improving existing tests for the UTF-8 transcoding logic. There's also a small amount of changing existing tests (in System.Text.Encoding and System.Reflection.Metadata) to react to bug fixes in
UTF8Encoding.Many of the new tests won't pass until dotnet/coreclr#21948 is checked in. I'm also trying to figure out which tests need to be suppressed on the older netfx platforms due to differences in the way
UTF8Encodingworks on netfx vs. corefx./cc @tmat and @nguerrera as owners of the Reflection metadata tests, which I'm tweaking.