This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Removing the explicit MicrosoftNetCompilersToolsetVersion definition so we get automatic updates from arcade. #36685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so we get automatic updates from arcade.
safern
approved these changes
Apr 8, 2019
Member
safern
left a comment
safern
left a comment
There was a problem hiding this comment.
LGTM -- the drawing test crashes is a known issue... https://github.com/dotnet/corefx/issues/36683
Was that the only issue with the merge? cc @Anipik |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already approved and merged in #36662.
However, it was immediately reverted (likely by accident) in #36656 as part of a merge conflict resolution.
I plan on merging as soon as CI passes.
CC. @safern, @stephentoub as an FYI.