Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Add more Decimal constructor tests #36668

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Add more Decimal constructor tests #36668

merged 1 commit into from
Apr 8, 2019

Conversation

@hughbe
Copy link

@hughbe hughbe commented Apr 7, 2019

No description provided.

@stephentoub
Copy link
Member

stephentoub commented Apr 7, 2019

Thanks. What was driving these additions? Trying to increase code coverage or something like that? If so, can you share the impact?

stephentoub
stephentoub approved these changes Apr 7, 2019
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@hughbe
Copy link
Author

hughbe commented Apr 7, 2019

A while ago I saw something moving native code to managed so wrote some tests to verify stuff but never ended up submitting. Went through my branches that were never sent in as a Pr And sent this in

@stephentoub
Copy link
Member

stephentoub commented Apr 7, 2019

A while ago I saw something moving native code to managed so wrote some tests to verify stuff but never ended up submitting. Went through my branches that were never sent in as a Pr And sent this in

So these tests are validating things that weren't previously validated? That's what I'm trying to figure out, whether this is actually new coverage or duplication.

@hughbe
Copy link
Author

hughbe commented Apr 8, 2019

So these tests are validating things that weren't previously validated?

Correct. These are new tests

@stephentoub stephentoub merged commit 47d17e3 into dotnet:master Apr 8, 2019
@hughbe hughbe deleted the decimal-tests branch April 9, 2019 07:03
@karelz karelz added this to the 3.0 milestone May 22, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@hughbe @stephentoub
Add more Decimal constructor tests (dotnet/corefx#36668)
ac1c1a3 
Commit migrated from dotnet/corefx@47d17e3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@stephentoub stephentoub stephentoub approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@hughbe @stephentoub @karelz