This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Consume Microsoft.DotNet.RemoteExecutor #36487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
changed the title
ViktorHofer
force-pushed
the
RemoteExecutor
branch
15 times, most recently
from
b71fbdf to
6042cdb
Compare
Member
Author
|
@ericstj @safern this is now ready to go in. Please take a look and also check the related one in arcade dotnet/arcade#2176. The sooner I get this in, the less conflicts I have to deal with :) |
ViktorHofer
commented
Mar 31, 2019
ViktorHofer
commented
Mar 31, 2019
ericstj
approved these changes
Apr 1, 2019
Member
ericstj
left a comment
ericstj
left a comment
There was a problem hiding this comment.
The integration looks nice and minimal. In the future please avoid publishing stable packages, even to a private feed. They tend to pollute things.
ViktorHofer
force-pushed
the
RemoteExecutor
branch
from
6042cdb to
854fd35
Compare
ViktorHofer
force-pushed
the
RemoteExecutor
branch
from
854fd35 to
8606ee5
Compare
ViktorHofer
force-pushed
the
RemoteExecutor
branch
from
8606ee5 to
8404816
Compare
ViktorHofer
force-pushed
the
RemoteExecutor
branch
from
d9e69e2 to
8404816
Compare
safern
reviewed
Apr 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires dotnet/arcade#2176
Commit 1 contains the infra work
Commit 2 the source changes
The failing arm64 leg is unrelated.
cc @danmosemsft