Allow single hyphen arguments in bash build #35628
Conversation
ViktorHofer
force-pushed
the
CLISyntax
branch
from
01d0430 to
67a9460
Compare
|
@sandreenko related to your ask (#34385 (comment)), it would be great if you could change the command to use -os and -arch after this went into master. |
|
cc @safern |
|
Should we also update corefx-base to benefit from this? i.e: not have conditions for common arguments, and we now can use -framework rather than short -f which is not as descriptive. https://github.com/dotnet/corefx/blob/master/eng/pipelines/corefx-base.yml#L110 |
|
Yeah I plan to do that as part of this PR :) |
ViktorHofer
force-pushed
the
CLISyntax
branch
from
55aa941 to
eb94619
Compare
|
Queued an official build: https://dnceng.visualstudio.com/internal/_build/results?buildId=109941. @safern any idea why the uapaot legs fail in the internal tools restore step with 401? |
ViktorHofer
force-pushed
the
CLISyntax
branch
from
eb94619 to
2729bbe
Compare
| - group: DotNet-HelixApi-Access | ||
| - _archiveTestsParameter: /p:ArchiveTests=Tests | ||
|
|
||
| - _args: -restore -build -configuration $(_BuildConfig) -ci -buildtests -arch $(_architecture) -framework $(_framework) $(_archiveTestsParameter) |
There was a problem hiding this comment.
Can we do this multiline? for readability purpose? Just like the call to the build script later on this file
There was a problem hiding this comment.
sure, if that's the only nit I would prefer do that in a follow-up PR (i.e. codecoverage)
|
|
||
| - _args: -restore -build -configuration $(_BuildConfig) -ci -buildtests -arch $(_architecture) -framework $(_framework) $(_archiveTestsParameter) | ||
| - _commonArguments: $(_args) | ||
| - _windowsOfficialBuildArguments: '' |
There was a problem hiding this comment.
Can you move this to where you're setting _msbuildCommonParameters: '' as well?
safern
left a comment
safern
left a comment
There was a problem hiding this comment.
Two small nits, they could probably wait until the Coverage PR, but wanted to call them out so that we don't forget.
|
Thanks @safern. Let's address them in the follow-up PR. |
* Allow single hyphen arguments in bash build * Add clean switch * Darc update from build '20190228.2' Commit migrated from dotnet/corefx@76e08b6
3 participants
React to the following change incoming from arcade: dotnet/arcade#2127. Will update this PR with the darc update later.
cc @jkotas