This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add GetSystemTimeAsTicks to System.Native #17484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The coreclr implementation was recently updated to use clock_gettime(CLOCK_REALTIME) for UtcNow: |
Member
Author
I will add this, where is the bit in the CMake goo that makes HAVE_WORKING_CLOCK_GETTIME work? |
Member
Member
|
We also have something similar (but not the same) in CoreFx already that you can basically copy and modify: corefx/src/Native/Unix/configure.cmake Line 340 in 8f671cb |
alexperovich
added a commit
to alexperovich/coreclr
that referenced
this pull request
Mar 24, 2017
Member
Author
|
OSX failing with #17487 @dotnet-bot test Innerloop OSX10.12 Debug x64 Build and Test please |
alexperovich
added a commit
to dotnet/coreclr
that referenced
this pull request
Mar 25, 2017
* Move DateTime to shared partition Depends on dotnet/corefx#17484 * Use CoreCLR specific impl of UtcNow on windows * Use the internal call on unix as well * Port good corert changes
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
Mar 25, 2017
* Move DateTime to shared partition Depends on dotnet/corefx#17484 * Use CoreCLR specific impl of UtcNow on windows * Use the internal call on unix as well * Port good corert changes
alexperovich
added a commit
to dotnet/corert
that referenced
this pull request
Mar 27, 2017
* Move DateTime to shared partition Depends on dotnet/corefx#17484 * Use CoreCLR specific impl of UtcNow on windows * Use the internal call on unix as well * Port good corert changes
dotnet-bot
pushed a commit
that referenced
this pull request
Jan 13, 2018
* Move DateTime to shared partition Depends on #17484 * Use CoreCLR specific impl of UtcNow on windows * Use the internal call on unix as well * Port good corert changes Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
dotnet-bot
pushed a commit
that referenced
this pull request
Jan 13, 2018
* Move DateTime to shared partition Depends on #17484 * Use CoreCLR specific impl of UtcNow on windows * Use the internal call on unix as well * Port good corert changes Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
safern
pushed a commit
that referenced
this pull request
Jan 16, 2018
* Move DateTime to shared partition Depends on #17484 * Use CoreCLR specific impl of UtcNow on windows * Use the internal call on unix as well * Port good corert changes Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
safern
pushed a commit
that referenced
this pull request
Jan 16, 2018
* Move DateTime to shared partition Depends on #17484 * Use CoreCLR specific impl of UtcNow on windows * Use the internal call on unix as well * Port good corert changes Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed by coreclr and corert for DateTime UtcNow