This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Refactor HTTP DiagnosticSource logging (part1 continued) #16385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiagnosticListener, send exception as separate event
Contributor
|
LGTM |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…activity_part1_refactoring_review Refactor HTTP DiagnosticSource logging (part1 continued) Commit migrated from dotnet/corefx@9ae1d51
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses post-review comments for PR #15971:
new
DiagnosticListener.IsEnabled()API is used to very efficiently determine if there is a subscriber to HttpDiagnoticListener and enable diagnostics.Exceptions are sent in a separate event
System.Net.Http.Exception, andSystem.Net.Http.Responseis still fired for all requests (successful, faulted and cancelled)Events documentation concerns will be addressed in next part (with Activity implementation)
/cc @stephentoub @vancem @avanderhoorn @nbilling @cwe1ss @karolz-ms @SergeyKanzhelev @brahmnes