This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix19817 #23912
Merged
Fix19817 #23912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I plan to add xunit tests to corefx |
Author
|
test Ubuntu x64 Formatting |
vitek-karas
reviewed
Apr 12, 2019
| throw new ArgumentNullException(nameof(partialName)); | ||
|
|
||
| return Load(partialName); | ||
| if ((partialName.Length == 0) || (partialName[0] == '\0')) |
Member
There was a problem hiding this comment.
Also - I think the Length will be zero if the first character is the nul terminator.
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Apr 12, 2019
Assembly.LoadFromPartialName(string) should not throw FileNotFoundException, but should rather return null. ArgumentException should use nameof(partialName) Fixes #19817 Signed-off-by: dotnet-bot <[email protected]>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Apr 12, 2019
Assembly.LoadFromPartialName(string) should not throw FileNotFoundException, but should rather return null. ArgumentException should use nameof(partialName) Fixes #19817 Signed-off-by: dotnet-bot <[email protected]>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/mono
that referenced
this pull request
Apr 12, 2019
Assembly.LoadFromPartialName(string) should not throw FileNotFoundException, but should rather return null. ArgumentException should use nameof(partialName) Fixes mono#19817 Signed-off-by: dotnet-bot <[email protected]>
marek-safar
pushed a commit
to mono/mono
that referenced
this pull request
Apr 12, 2019
Assembly.LoadFromPartialName(string) should not throw FileNotFoundException, but should rather return null. ArgumentException should use nameof(partialName) Fixes #19817 Signed-off-by: dotnet-bot <[email protected]>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Apr 12, 2019
Assembly.LoadFromPartialName(string) should not throw FileNotFoundException, but should rather return null. ArgumentException should use nameof(partialName) Fixes #19817 Signed-off-by: dotnet-bot <[email protected]>
GrabYourPitchforks
pushed a commit
to dotnet/corefx
that referenced
this pull request
Apr 12, 2019
Assembly.LoadFromPartialName(string) should not throw FileNotFoundException, but should rather return null. ArgumentException should use nameof(partialName) Fixes #19817 Signed-off-by: dotnet-bot <[email protected]>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Apr 14, 2019
Assembly.LoadFromPartialName(string) should not throw FileNotFoundException, but should rather return null. ArgumentException should use nameof(partialName) Fixes #19817 Signed-off-by: dotnet-bot <[email protected]>
davmason
pushed a commit
to davmason/coreclr
that referenced
this pull request
Apr 27, 2019
Assembly.LoadFromPartialName(string) should not throw FileNotFoundException, but should rather return null. ArgumentException should use nameof(partialName) Fixes #19817
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Assembly.LoadFromPartialName(string) should not throw FileNotFoundException, but should rather return null. ArgumentException should use nameof(partialName) Fixes dotnet/coreclr#19817 Commit migrated from dotnet/coreclr@daa688d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assembly.LoadFromPartialName(string) should not throw FileNotFoundException
rather it should return null.
Fixes #19817