Skip to content

Conversation

@danroth27
Copy link
Member

No description provided.

@danroth27
Copy link
Member Author

@guardrex

Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@jamesmontemagno jamesmontemagno merged commit 4b89d7d into dotnet10-p4 May 13, 2025
2 checks passed
@jamesmontemagno jamesmontemagno deleted the aspnetcore10p4 branch May 13, 2025 05:03
rbhanda pushed a commit that referenced this pull request May 13, 2025
* Add .NET 10 Preview 4

* adding release notes for ef core

* updated cosmos section of ef docs and added missing small improvements

* fixed headings

* fix linter error in ef docs

* Update 10.0 Preview 4 Release notes (#9867)

* Update winforms.md

First draft with copilit

* Review feedback

latest updates

* Update winforms.md

* Update release-notes/10.0/preview/preview4/winforms.md

Co-authored-by: Tanya Solyanik <[email protected]>

* Update release-notes/10.0/preview/preview4/winforms.md

Co-authored-by: Tanya Solyanik <[email protected]>

* Update release-notes/10.0/preview/preview4/winforms.md

Co-authored-by: Tanya Solyanik <[email protected]>

* Update release-notes/10.0/preview/preview4/winforms.md

Co-authored-by: Tanya Solyanik <[email protected]>

* Update release-notes/10.0/preview/preview4/winforms.md

Co-authored-by: Tanya Solyanik <[email protected]>

---------

Co-authored-by: Tanya Solyanik <[email protected]>

* cleanup

* update C# 14

* .NET 10 Preview 4 - Containers (#9879)

* add here

* udpate

* update links

* Updated [dotnet-sdk-win-x86.zip] link 10.0.0-preview.4.md

* .NET 10 Preview 4 - Libraries (#9875)

* update here

* Add Out-of-Proc Trace Support for Activity Events and Links

* Rate Limiting Trace Sampling Support

* Clean-ip

* minor touch

* zip async

* gzip perf improvement

* Update release-notes/10.0/preview/preview4/libraries.md

Co-authored-by: Martin Costello <[email protected]>

* Update release-notes/10.0/preview/preview4/libraries.md

Co-authored-by: Rich Lander <[email protected]>

* updates

---------

Co-authored-by: Tarek Mahmoud Sayed <[email protected]>
Co-authored-by: Carlos Sánchez López <[email protected]>
Co-authored-by: Rich Lander <[email protected]>
Co-authored-by: Martin Costello <[email protected]>

* .NET 10 Preview 4 - WPF (#9877)

* Add here

* Add WPF notes

* Add blurb about breaking changes

* cleanup messagebox stuff

* Update release-notes/10.0/preview/preview4/wpf.md

Co-authored-by: Harshit <[email protected]>

---------

Co-authored-by: Andy (Steve) De George <[email protected]>
Co-authored-by: Harshit <[email protected]>

* .NET 10 Preview 4 - SDK (#9876)

* add here

* update

* .NET 10 Preview 4 - Runtime (#9874)

* Update runtime.md

* Add JIT notes

* Update inlining notes

Co-authored-by: Andy Ayers <[email protected]>

* Remove whitespace

* Brevity

Co-authored-by: Rich Lander <[email protected]>

* cleanup top links

---------

Co-authored-by: Aman Khalid (from Dev Box) <[email protected]>
Co-authored-by: Andy Ayers <[email protected]>
Co-authored-by: Rich Lander <[email protected]>

* Add ASP.NET Core release notes for .NET 10 Preview 4 (#9881)

* Add ASP.NET Core release notes for .NET 10 Preview 4

* Add IJSObjectReference to JS function

* Update release-notes/10.0/preview/preview4/aspnetcore.md

Co-authored-by: Martin Costello <[email protected]>

* Fix OpenAPI.NET version

* Add todo for remaining features

* Add WebApplicationFactory with Kestrel

* Update todos

* Update todos

* Add NavigationManager.NotFound

* Add Blazor WebAssembly runtime diagnostics

* Edits

* Edits

* Edits

---------

Co-authored-by: Martin Costello <[email protected]>

* cleanup

* linter

* Address default Blazor UI template update.

* Add hyphen to dotnet-gcdump

* some updates

* updates

* .NET MAUI in .NET 10 Preview 4 (#9873)

* .NET MAUI in .NET 10 Preview 4

* added new MAUI features

* updates for known issues

* updates

---------

Co-authored-by: James Montemagno <[email protected]>

* fix up md

* Update install-linux.md

* Update install-macos.md

* Update install-windows.md

* Update releases.json

* Updated release date in README.md

* Updated line16 with preview4 in releases.json

---------

Co-authored-by: maumar <[email protected]>
Co-authored-by: Merrie McGaw <[email protected]>
Co-authored-by: Tanya Solyanik <[email protected]>
Co-authored-by: victorisr <[email protected]>
Co-authored-by: Tarek Mahmoud Sayed <[email protected]>
Co-authored-by: Carlos Sánchez López <[email protected]>
Co-authored-by: Rich Lander <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Andy (Steve) De George <[email protected]>
Co-authored-by: Harshit <[email protected]>
Co-authored-by: Aman Khalid (from Dev Box) <[email protected]>
Co-authored-by: Andy Ayers <[email protected]>
Co-authored-by: Daniel Roth <[email protected]>
Co-authored-by: David Ortinau <[email protected]>
Co-authored-by: padmasrid <[email protected]>

ASP.NET Core now provides enhanced support for OpenAPI XML documentation comments, particularly for complex types. The updated generator also skips processing problematic complex types, preventing build errors and ensuring smoother builds. Note that this may result in missing metadata in some cases.

You can also now configure XML documentation processing to include comments from other assemblies. This is helpful for documenting types defined outside the current assembly, like `ProblemDetails` from the ASP.NET Core shared framework.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page mentions "ProblemDetails from the ASP.NET Core shared framework"
While the What's New Issue Comment mentions ProblemDetails as a type in the Microsoft.AspNetCore.Http assembly.

Both are out of sync with the sample XML, which refers to Microsoft.AspNetCore.Http.Abstractions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdykstra ProblemDetails is a type in the Microsoft.AspNetCore.Mvc namespace in the Microsoft.AspNetCore.Http.Abstractions.dll assembly, which is part of the ASP.NET Core shared framework. So, I think the What's New Issue Comment just had a typo in it. @mikekistler Can you confirm?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unclear on what the problem is here. I think @danroth27 is correct that:

ProblemDetails is a type in the Microsoft.AspNetCore.Mvc namespace in the Microsoft.AspNetCore.Http.Abstractions.dll assembly, which is part of the ASP.NET Core shared framework.

But I'm not sure what the "typo" is in the comment. Maybe my old eyes just don't see it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue comment speaks of the Microsoft.AspNetCore.Http assembly; I think it should be called the Microsoft.AspNetCore.Http.Abstractions assembly as it is referenced in the XML sample(?)
GitHub Copilot says The Microsoft.AspNetCore.Http assembly and the Microsoft.AspNetCore.Http.Abstractions assembly serve different purposes and should not be used interchangeably:...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay ... I think I understand now. I was confused because the comment is here -- where there is no problem (I think) -- but the problem was in the comment on the issue. I have updated the comment -- I hope that resolves things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants